This repository has been archived by the owner. It is now read-only.

rename loggedInEmail to loggedInUser with backcompat support. issue #18... #1806

Merged
merged 2 commits into from Jun 29, 2012

Conversation

Projects
None yet
4 participants
Contributor

lloyd commented Jun 20, 2012

...05

resources/static/include_js/include.js
+ {
+ options.loggedInUser = options.loggedInEmail;
+ delete options.loggedInEmail;
+ }
@callahad

callahad Jun 20, 2012

Owner

Looks good! Pedantry -- shouldn't this be using same-line curly braces to match the rest of this file?

Owner

callahad commented Jun 20, 2012

Should we add a unit test for this? Otherwise, r+.

Contributor

benadida commented Jun 20, 2012

@callahad is right, we need tests, I guess this means we wait until early next week to merge, that's probably ok.

Contributor

lloyd commented Jun 25, 2012

oh damn. This means we can't really call the .watch() api stable when we roll 2012.06.22 on july 4th.

shane-tomlinson added a commit that referenced this pull request Jun 29, 2012

Merge pull request #1806 from mozilla/issue1805
rename loggedInEmail to loggedInUser with backcompat support.  issue #18...

There are not yet proper front end tests of include.js, @lloyd and I are going to have Zac add Selenium tests for this.

In lieu of unit tests, I have tested this manually and am comfortable with the changes.  I added a console.log message stating loggedInEmail has been deprecated and updated the curly brace style.

r+

close #1805

@shane-tomlinson shane-tomlinson merged commit d3b9a1f into dev Jun 29, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.