Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove eyedee.me related wclickIfExists invocations #2734

Merged
merged 1 commit into from Nov 19, 2012

Conversation

Projects
None yet
2 participants
Member

shane-tomlinson commented Nov 19, 2012

  • When redirecting to eyedee.me, add a small delay before continuing to ensure time for the click handler to be hooked up.
  • Renenable the returning-user, remove-email, and add-primary-to-secondary tests.

@6a68 - mind reviewing this?

@shane-tomlinson shane-tomlinson Remove eyedee.me related wclickIfExists invocations
* When redirecting to eyedee.me, add a small delay before continuing to ensure time for the click handler to be hooked up.
* Renenable the returning-user, remove-email, and add-primary-to-secondary tests.
7a96b46
Owner

6a68 commented Nov 19, 2012

@shane-tomlinson This is the sorta situation where abstracting out something like POMs, but flow-oriented, would be nice (instead of having to duplicate the fix across the codebase). However, I don't want us to rush to clunky abstraction, so r+ from me.

@6a68 6a68 added a commit that referenced this pull request Nov 19, 2012

@6a68 6a68 Merge pull request #2734 from shane-tomlinson/test-stabilization
Remove eyedee.me related wclickIfExists invocations
5928dde

@6a68 6a68 merged commit 5928dde into mozilla:dev Nov 19, 2012

1 check was pending

default The Travis build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment