Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

Disable CSP, as it caused breakage on FxOS #4150

Merged
merged 1 commit into from Jun 13, 2014
Merged

Disable CSP, as it caused breakage on FxOS #4150

merged 1 commit into from Jun 13, 2014

Conversation

callahad
Copy link
Contributor

Fixes #4144

Leaving comments in each file to avoid future well-intentioned changes breaking
it again.

CSPs were introduced in commit 0e0f47b

Fixes #4144

Leaving comments in each file to avoid future well-intentioned changes breaking
it again.

CSPs were introduced in commit 0e0f47b
@callahad
Copy link
Contributor Author

All tests pass locally.

...waits for Travis...

@jaredhirsch
Copy link
Member

Should we also remove the csp key from lib/configuration.js?

@callahad
Copy link
Contributor Author

I think not, since it's a known-good CSP, that happens to just be untenable on FxOS.

@jaredhirsch
Copy link
Member

Hmm, having trouble logging in on localhost after this change

@jaredhirsch
Copy link
Member

I'm getting an unrelated bidbundle error locally, r+, merging

jaredhirsch added a commit that referenced this pull request Jun 13, 2014
Disable CSP, as it caused breakage on FxOS
@jaredhirsch jaredhirsch merged commit 8987aec into dev Jun 13, 2014
@jaredhirsch jaredhirsch deleted the disable-csp branch June 13, 2014 22:21
@shane-tomlinson
Copy link

Could you do something like enable CSP for all known good browsers and disable for FxOS?

@shane-tomlinson
Copy link

You could also set CSP to report-only to see which browsers CSP causes issues in.

See https://developer.mozilla.org/en-US/docs/Web/Security/CSP/Using_Content_Security_Policy#Testing_your_policy

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants