Skip to content
This repository has been archived by the owner. It is now read-only.

Revert "Fix how rpInfo is created in native Desktop authentication flow" #4154

Merged
merged 2 commits into from Jul 17, 2014

Conversation

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Jun 23, 2014

This reverts commit 4172e25.

Edit: fixes #4144.

@jaredhirsch
Copy link
Member

@jaredhirsch jaredhirsch commented Jun 23, 2014

Adding some context:

It looks like this commit broke primaries on FxOS because it sets navigator.id = navigator.mozId, but then we try to add properties to navigator.id. In FxOS, navigator.mozId is immutable, and will silently fail if we try to modify it. This is a pretty good guess as to the cause of #4144.

@jaredhirsch
Copy link
Member

@jaredhirsch jaredhirsch commented Jul 17, 2014

Looks like this fix works on stage, see discussion in #4144. Merging.

jaredhirsch added a commit that referenced this pull request Jul 17, 2014
Revert "Fix how rpInfo is created in native Desktop authentication flow"
@jaredhirsch jaredhirsch merged commit 298bde6 into dev Jul 17, 2014
1 check passed
1 check passed
@jaredhirsch
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants