Navigation Menu

Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

update vows and wd versions #4168

Merged
merged 1 commit into from Jul 25, 2014
Merged

Conversation

edwindotcom
Copy link
Contributor

this fixed #4167 on my mac.

@pdehaan
Copy link
Contributor

pdehaan commented Jul 24, 2014

If ye change the package.json, do ye need to change the lockdown.json as well?
Nevermind, I just saw that this wasn't the main package.json, but is in a non-lockdown-ed subdir.

@edwindotcom
Copy link
Contributor Author

@pdehaan out of dumb luck - the root lockdown file has vows defined:
https://github.com/mozilla/persona/blob/dev/lockdown.json#L486

and wd was never lockeddown anywhere

@edwindotcom
Copy link
Contributor Author

I ran this with dev and current train branch and tests were able to run.

@karlht
Copy link
Contributor

karlht commented Jul 25, 2014

@edmoz, me too. Pushing the big green button.

karlht added a commit that referenced this pull request Jul 25, 2014
@karlht karlht merged commit bbe809a into mozilla:dev Jul 25, 2014
@edwindotcom
Copy link
Contributor Author

woot!

@edwindotcom edwindotcom deleted the fix-auto-test-versions branch July 25, 2014 22:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants