Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixing a problem where the expiration date for the assertions was being c #458
Fixing a problem where the expiration date for the assertions was being calculated incorrectly.
Adding basic assertion tests to make sure all of the necessary parts are there and that the expiration date is actually a date.
I was unsure of what to include in the assertion tests. Since it is a unit test, I did not want to call the backend, which would make it more of a functional test. Ideas, suggestions, fixes are all appreciated.
can we do a tighter check on the assertion? Test that it's expiration date is two minutes from now +- 5s? This check will verify we don't regress on GH-433