This repository has been archived by the owner. It is now read-only.

Fixing a problem where the expiration date for the assertions was being c #458

Merged
merged 2 commits into from Oct 19, 2011

Conversation

Projects
None yet
3 participants
@shane-tomlinson
Member

shane-tomlinson commented Oct 18, 2011

Fixing a problem where the expiration date for the assertions was being calculated incorrectly.

Adding basic assertion tests to make sure all of the necessary parts are there and that the expiration date is actually a date.

I was unsure of what to include in the assertion tests. Since it is a unit test, I did not want to call the backend, which would make it more of a functional test. Ideas, suggestions, fixes are all appreciated.

issue #457

Fixing a problem where the expiration date for the assertions was bei…
…ng calculated incorrectly.

Adding basic assertion tests to make sure all of the necessary parts are there and that the expiration date is actually a date.

issue #457
@lloyd

This comment has been minimized.

Show comment
Hide comment
@lloyd

lloyd Oct 18, 2011

Contributor

why not:

var expirationDate = new Date(expirationMS);

?

Contributor

lloyd commented on browserid/static/dialog/resources/user.js in 79ee0da Oct 18, 2011

why not:

var expirationDate = new Date(expirationMS);

?

@lloyd

This comment has been minimized.

Show comment
Hide comment
@lloyd

lloyd Oct 18, 2011

Contributor

can we do a tighter check on the assertion? Test that it's expiration date is two minutes from now +- 5s? This check will verify we don't regress on GH-433

can we do a tighter check on the assertion? Test that it's expiration date is two minutes from now +- 5s? This check will verify we don't regress on GH-433

Update with @lloyd's requests. Tighter check on the assertion expirat…
…ion date. Simpler creation of the expiration date.

lloyd added a commit that referenced this pull request Oct 19, 2011

Merge pull request #458 from mozilla/assertion_date
Fixes invalid assertion generation due to misset assertion expires field.

closes #457

introduced by @lloyd in attempted fix to #433

@lloyd lloyd merged commit 89a8231 into dev Oct 19, 2011

@jbonacci

This comment has been minimized.

Show comment
Hide comment
@jbonacci

jbonacci Oct 26, 2011

Contributor

No verification testing needed by QA.

Contributor

jbonacci commented Oct 26, 2011

No verification testing needed by QA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.