Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Unsupported dialog and LOADS of related changes, for issue #273 #484
This is the unsupported dialog and all of its related changes. There are so many commits because the original browser check was placed into the main dialog code. This did not work for browsers that do not have postMessage as the channel is never established. Afterwards I moved a lot of this logic into include.js and created a new dialog page which is served up to unsupported browsers.
The most important part to review is the additional backend unit test named page-requests-test.js. This now makes use of the wsapi client so it is standard. https://github.com/mozilla/browserid/blob/245e4f6879656b607a1274ad8bbede67a406d7c4/browserid/tests/page-requests-test.js
I retained the BrowserSupport.js file and related unit tests even though the BrowserSupport code is pulled into include.js because in the near future I want to split include.js into several files for testing purposes and do not want to rewrite this code.
dialog.ejs has been split into dialog.ejs and dialog_layout.ejs. This is so we can have one generic layout template to use across all current and future dialogs, including the new unsupported_dialog.ejs