This repository has been archived by the owner. It is now read-only.

Unsupported dialog and LOADS of related changes, for issue #273 #484

Closed
wants to merge 33 commits into
base: dev
from

Conversation

Projects
None yet
2 participants
@shane-tomlinson
Member

shane-tomlinson commented Oct 26, 2011

This is the unsupported dialog and all of its related changes. There are so many commits because the original browser check was placed into the main dialog code. This did not work for browsers that do not have postMessage as the channel is never established. Afterwards I moved a lot of this logic into include.js and created a new dialog page which is served up to unsupported browsers.

The most important part to review is the additional backend unit test named page-requests-test.js. This now makes use of the wsapi client so it is standard. https://github.com/mozilla/browserid/blob/245e4f6879656b607a1274ad8bbede67a406d7c4/browserid/tests/page-requests-test.js

I retained the BrowserSupport.js file and related unit tests even though the BrowserSupport code is pulled into include.js because in the near future I want to split include.js into several files for testing purposes and do not want to rewrite this code.

dialog.ejs has been split into dialog.ejs and dialog_layout.ejs. This is so we can have one generic layout template to use across all current and future dialogs, including the new unsupported_dialog.ejs

shane-tomlinson added some commits Oct 20, 2011

Starting to work on the unsupported screen.
Adding a controller, tests, adding browser-support.js and tests.

issue #273
Making renderError follow the same pattern as renderBody, renderWait.…
… Can pass errorTemplate and errorVars to the init function.

Updating the tests for this.
Starting to work on the unsupported screen.
Adding a controller, tests, adding browser-support.js and tests.

issue #273
Making renderError follow the same pattern as renderBody, renderWait.…
… Can pass errorTemplate and errorVars to the init function.

Updating the tests for this.
Merge branch 'unsupported' of github.com:mozilla/browserid into unsup…
…ported

Conflicts:
	browserid/static/dialog/controllers/dialog_controller.js
Starting to add the unsupported dialog as its own page.
Adding unsupported_dialog as a path.

Making both signin and unsupported ailog use dialog_layout as its layout.

Adding unit tests to make sure the front facing pages we expect are actually there.

issue #273
Removing fragments of partial ideas.
* IE specific message from unsupported_dialog.ejs
* reason (which went to unsupported_dialog) from app.js
* last bits of checkSupport from dialog_controller.js

issue #273
Merge branch 'dev' into unsupported
Conflicts:
	browserid/static/dialog/controllers/dialog_controller.js
	browserid/static/dialog/controllers/page_controller.js
Merge branch 'dev' into unsupported
Conflicts:
	browserid/static/dialog/qunit.html
	browserid/static/dialog/test/qunit/qunit.js
@lloyd

This comment has been minimized.

Show comment
Hide comment
@lloyd

lloyd Oct 26, 2011

Contributor

I don't find the individual commits here very useful, I would prefer to squash merge this...

Contributor

lloyd commented Oct 26, 2011

I don't find the individual commits here very useful, I would prefer to squash merge this...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.