Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add browserid library #73

Closed
fwenzel opened this Issue Sep 28, 2011 · 10 comments

Comments

Projects
None yet
5 participants
Member

fwenzel commented Sep 28, 2011

Hooking playdoh into browserid should be stupid-simple.

How we do it is up for debate, either bundle django-browserid with playdoh, or add it to the list of known libraries if we fear bloat. Might need some best-practices docs around it, too.

Member

tofumatt commented Sep 28, 2011

I don't fear bloat, for what it's worth. BrowserID is pretty slick and really central to Mozilla's identity stuff, so we should ship it with playdoh.

Contributor

peterbe commented Sep 29, 2011

Because it's not "settled" unlike some other less changing libraries I would prefer that we don't put it into playdoh or playdoh-lib yet. Thing is, django-browserid is bound to change a lot as BrowserID changes. Also, since so many of our Django projects use (Mozilla) LDAP plus the fact that django-sasl isn't finished yet all these LDAP projects can't yet switch to BrowserID.

Hmm... writing about this makes me think I should fold django-auth-ldap into playdoh and playdoh-lib mayhaps.

Member

fwenzel commented Sep 29, 2011

You bring up good points Peter. However, I disagree that many of our django apps use LDAP. In fact, the least of them do. Eventually, I'd like to see browserid bundled with playdoh (or django, for that matter!) because it's a very generic login mechanism useful for anyone, while LDAP is very corporate.

Member

tofumatt commented Sep 29, 2011

Yeah; LDAP is a very special-case storage backend, and frankly: I'd like to encourage people to think about whether they really need it before they integrate it. Making it slightly harder by not bundling LDAP libraries actually makes sense to me.

Contributor

peterbe commented Sep 30, 2011

In retrospect my comment sounded very negative. I'm not against preparing playdoh'ers for BrowserID. The three playdoh projects I maintain aren't ready to use it till we get django-sasl. All of mine are LDAP based. Biased world-view.

@tofumatt, very good point about NOT poisoning playdoh with a always-troubling python-ldap.

Member

fwenzel commented Sep 30, 2011

It's all good. Actually interesting to see how much our projects differ!

Member

ozten commented Oct 26, 2011

I strongly feel that we should add django-browserid to playdoh-lib.

If we don't dogfood BrowserID, why would we expect other real world webapps to adopt it?

New projects start with Playdoh and should also start with BrowserID.

I'm adding BrowserID to Affiliates. Once this is done, I plan on proposing that work as a pull request to Playdoh too.

Member

fwenzel commented Oct 26, 2011

I'm adding BrowserID to Affiliates. Once this is done, I plan on proposing that work as a pull request to Playdoh too.

Please do.

Member

ozten commented Nov 30, 2011

Hmm, I haven't found time to integrate this. Passing the torch.

Owner

Osmose commented Jun 6, 2012

Aaaaaaand fixed!

#109
mozilla/playdoh-lib#16
mozilla/funfactory#29

Many thanks to @rfreebern for the patches and subsequent changes. \o/

@Osmose Osmose closed this Jun 6, 2012

@Osmose Osmose referenced this issue Jun 6, 2012

Open

Register/Login? #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment