Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Password protected Vimeo - Events don't fire #349

Open
rockingskier opened this Issue Oct 2, 2013 · 1 comment

Comments

Projects
None yet
2 participants

When the Vimeo video is password protected the player is created but with Vimeo's password overlay (as you'd want). However no events are fired either before or after entering the password.

I have tried most events and none of them fire.

As an example I have Big Buck Bunny hidden behind a password.

  1. Enter password: hippo
  2. See no events firing
  3. Press play
  4. Still no events
  5. Re-run fiddle
  6. See 'durationchange' is fired
  7. Press play
  8. Lots of 'timeupdate' events

(Posted on SO as well)

Contributor

ScottDowne commented Oct 3, 2013

This is a bug, and an unexpected use case.

What happens is normally popcorn waits for the video to be ready and sets
up needed data to connect with the video, including events.

What I think in the case of the password protected video, the video does
not register any events to popcorn, including ready, until the password is
entered, but I suspect by the time the password is entered, the needed
vimeo events, like ready and duration change, have already been fired and
missed because they were blocked by the password. Because we never got a
ready event, we never setup any other events.

Once the password has been entered once, refreshing the page caches the
password and everything works. Something to look into.

I suspect this is fixable.

On 2 October 2013 11:47, Ben notifications@github.com wrote:

When the Vimeo video is password protected the player is created but with
Vimeo's password overlay (as you'd want). However no events are fired
either before or after entering the password.

I have tried most events and none of them fire.

As an example I have Big Buck Bunnyhttp://jsfiddle.net/rockingskier/7hXCd/5/hidden behind a password.

  1. Enter password: hippo
  2. See no events firing
  3. Press play
  4. Still no events
  5. Re-run fiddle
  6. See 'durationchange' is fired
  7. Press play
  8. Lots of 'timeupdate' events

(Posted on SOhttp://stackoverflow.com/questions/19133840/popcornjs-password-protected-vimeo-video-events-not-firedas well)


Reply to this email directly or view it on GitHubhttps://github.com/mozilla/popcorn-js/issues/349
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment