Skip to content

[#1330] Create a wrapper elem right away, add it to the dom on ready. Th... #266

Open
wants to merge 2 commits into from

2 participants

@ScottDowne

...is allows calls to height/width before loaded is done, without crash.

@ScottDowne ScottDowne [#1330] Create a wrapper elem right away, add it to the dom on ready.…
… This allows calls to height/width before loaded is done, without crash.
6d6235a
@cadecairos cadecairos commented on the diff Jan 17, 2013
...pers/soundcloud/popcorn.HTMLSoundCloudAudioElement.js
@@ -244,7 +239,7 @@
player.unbind( SC.Widget.Events.FINISH );
parent.removeChild( elem );
- elem = null;
+ elem = document.createElement( "iframe" )
@cadecairos
Mozilla member
cadecairos added a note Jan 17, 2013

Missing semicolon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.