T913735 #351

Open
wants to merge 11 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

ScottDowne commented Oct 15, 2013

No description provided.

Contributor

rwaldron commented Oct 15, 2013

"No description given", more like "No tests given" ;)

Contributor

ScottDowne commented Oct 15, 2013

Tests given \o/

Contributor

rwaldron commented Oct 15, 2013

:)

+ }
+ }
+
+ if (msg === "No suitable players found and fallback enabled" ) {
@mjschranz

mjschranz Oct 16, 2013

Contributor

Space nit.

@mjschranz

mjschranz Oct 16, 2013

Contributor

Nit. Let's store this string somewhere since it matches the message below.

+ if (msg === "No suitable players found and fallback enabled" ) {
+ onPlayerError({
+ message: "No suitable players found and fallback enabled",
+ code: 4
@mjschranz

mjschranz Oct 16, 2013

Contributor

Significance behind this number?

@ScottDowne

ScottDowne Oct 17, 2013

Contributor

That's the error code html5 throws if you try to play something that's not playable. Example, the string "garbage" like we have in the html5 wrapper tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment