Print preview does not work #519

Closed
aleth opened this Issue Jun 8, 2011 · 4 comments

Projects

None yet

4 participants

@aleth
aleth commented Jun 8, 2011

Print preview, which worked fine in LessChrome 6, seems to be broken again (i.e. the print preview toolbar is not displayed).

@morby
morby commented Jun 20, 2011

I was just about to comment on that. Yes, LessChrome eats the very necessary Print Preview bar and mousing over where it should be no longer brings it back.

@haoshu
haoshu commented Jun 28, 2011

exactly the same problem. here is my ad-hoc remedy. hope it helps.

  1. install Custom Buttons or keyconfig
    https://addons.mozilla.org/ja/firefox/addon/custom-buttons/
    http://forums.mozillazine.org/viewtopic.php?f=48&t=72994
  2. define a new button or hotkey
  3. assign the code below to your new button or key, which will act as a flip-flop switch to turn LessChrome ON/OFF
    // Begin Code
    Components.utils.import('resource://gre/modules/AddonManager.jsm');
    AddonManager.getAddonByID(
    'lessChrome.HD@prospector.labs.mozilla',
    function(addon) {
    if (addon && addon.isActive) {
    addon.userDisabled = true;
    }
    else {
    addon.userDisabled = false;
    }
    });
    // End of Code
  4. turn LessChrome ON/OFF when needed
@aleth
aleth commented Sep 9, 2011

This regression is due to this commit
6a9ff74

Undoing it fixes the problem. (It is unclear to me however which problem the commit was trying to address, so I can't say what other bug might reappear if you do this.)

@aleth
aleth commented Sep 9, 2011

Ah, it fixes the print preview regression, but it sometimes prevents adjustment of the offset after a the URL bar is hidden, leading either to a grey bar at the top of the screen or to issue #516, as the case may be.

@aleth aleth pushed a commit to aleth/prospector that referenced this issue Sep 10, 2011
aleth Fix for issue #519: Make print preview usable f0c8a2f
@Mardak Mardak added a commit that closed this issue Sep 22, 2011
aleth Closes #519: Print preview does not work [r=Mardak]
Make print preview usable
(cherry picked from commit f0c8a2f)
f1b7363
@Mardak Mardak closed this in f1b7363 Sep 22, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment