Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Convert Instant Preview to a Jetpack #617

Open
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

erikvold commented Aug 6, 2011

No description provided.

Contributor

grssam commented Aug 6, 2011

will this help anyhow ?

Contributor

erikvold commented Aug 6, 2011

It'll mean we don't have to copy scripts into each addon folder, albeit that could be achieved with a little effort anyhow.

It'll mean we can utilize a good test framework and documentation system.

It'll mean others can use the code far more easily.

Requiring modules is a way of revealing the features a add-on uses, which will be info made available to users at some point afaik.

Having the Prospector team use the Add-on SDK will improve the SDK.

Member

Mardak commented Oct 7, 2011

How do you build a xpi with this structure? I see that you put the common libs in the parent directory with its own package.json.

But if I run "cfx xpi" from instantPreview/ directory:

cuddlefish.packaging.PackageNotFoundError: prospector (required by 'prospector-instant-preview')

Contributor

erikvold commented Oct 7, 2011

There may be a better way to link the package, or to organize this project, I don't claim to think this is optimal, but I did want to reuse modules, so this is why I did what I did.

To link the prospector package with your addon sdk you have a number of options, but what I do is make a soft link from the addon-sdk/packages dir called prospector which points to my checkout of this repo.

$ ln -s ~/github/prospector/ ~/github/addon-sdk/packages/prospector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment