This repository has been archived by the owner. It is now read-only.

updating all apps on addon update causes Simulator to start unexpectedly #308

Closed
mykmelez opened this Issue Feb 11, 2013 · 4 comments

Comments

Projects
None yet
5 participants
@mykmelez
Member

mykmelez commented Feb 11, 2013

Updating an app causes the Simulator to start if it isn't already running. That's ok when the user triggers the update by pressing the app's Update button, since it's clear that the Simulator started as a result of the button press, and the user probably wants to test the app after updating it.

But it's a problem when an addon update triggers updating all apps, because it isn't clear why the Simulator started in that case, especially if the Dashboard is closed. Launching the Simulator then is unexpected and startles the user.

We have to start the Simulator to update an app. But that is a technical implementation detail. And we shouldn't expose the user to it. The Simulator should only start when the user asks it to, either because they press the Start button or because they press the Update button for a particular app.

We could fix this by starting the Simulator in a special "install app" mode when updating all apps while the Simulator is not running. The mode, triggered by a command-line flag, would install the app specified on the command line (or multiple apps specified in a temporary file) and then quit. All without ever opening a window. So the user will never see the Simulator.

cc: @rpl

@mykmelez

This comment has been minimized.

Show comment
Hide comment
Member

mykmelez commented Feb 12, 2013

@robcee

This comment has been minimized.

Show comment
Hide comment
@robcee

robcee Feb 13, 2013

so that's what happened!

robcee commented Feb 13, 2013

so that's what happened!

@kumar303

This comment has been minimized.

Show comment
Hide comment
@kumar303

kumar303 Feb 13, 2013

Member

Hah. I was so confused.

Member

kumar303 commented Feb 13, 2013

Hah. I was so confused.

@willbprog127

This comment has been minimized.

Show comment
Hide comment
@willbprog127

willbprog127 Feb 13, 2013

Ah, okay, just filed an issue about this...will delete it (if I can)

willbprog127 commented Feb 13, 2013

Ah, okay, just filed an issue about this...will delete it (if I can)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.