js_message leaks message wrappers to avoid crash #825

Open
mykmelez opened this Issue Sep 5, 2013 · 0 comments

Projects

None yet

1 participant

@mykmelez
Mozilla member

#820 introduces a memory leak of message wrappers in js_message in order to avoid a crash:

+  // TODO: Fix this memory leak by figuring out why there is bad access when the
+  // destructor calls free_js_msg (even if the function is empty).
+  thread_store_set(&js_msg_key, wrapper, /* free_js_msg */ NULL);

We should figure out why the crash is happening and resolve that issue so we can plug the leak.

cc: @brendandahl, @bkase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment