New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use improvement patches built by analyzers #1624

Merged
merged 6 commits into from Oct 18, 2018

Conversation

Projects
None yet
2 participants
@La0
Collaborator

La0 commented Oct 18, 2018

Part 2/3 of #1271

@La0 La0 self-assigned this Oct 18, 2018

@La0 La0 requested a review from marco-c Oct 18, 2018

La0 added a commit to La0/mozilla-relengapi that referenced this pull request Oct 18, 2018

@@ -276,74 +259,18 @@ def detect_issues(self, analyzers, revision):
analyzer = analyzer_class()
# Run analyzer on revision and store generated issues
issues += analyzer.run(revision)
analyser_issues = analyzer.run(revision)
issues += analyser_issues

This comment has been minimized.

@marco-c

marco-c Oct 18, 2018

Member

Nit: this change seems unneeded

This comment has been minimized.

@La0

La0 Oct 18, 2018

Collaborator

Totally, that's a leftover

logger = get_logger(__name__)
TaskCluster = collections.namedtuple('TaskCluster', 'results_dir, task_id, run_id, online')

This comment has been minimized.

@marco-c

marco-c Oct 18, 2018

Member

Nit: online is not a great name, but I don't have another idea unless we make it the opposite and call it local

@marco-c

Looks good to me overall, it's cleaning up a bit.
One thing we might want to keep doing is to try applying the patch to see if it actually applies cleanly.

La0 added some commits Oct 18, 2018

@La0 La0 merged commit 002aed1 into mozilla:master Oct 18, 2018

1 check passed

Taskcluster (pull_request) TaskGroup: success
Details

@La0 La0 deleted the La0:sa-patches branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment