Add a tool 'uplift_beta' to set a ni when a bug is fixed in nightly and is affecting beta #912
Conversation
…nd is affecting beta
| return {bugid: info for bugid, info in bugs.items() if bugid in data} | ||
|
|
||
| def filter_by_regr(self, bugs): | ||
| # Filter the bugs which don't have any regression or where the regressions are all closed |
marco-c
Mar 3, 2020
Contributor
Maybe when there are regressions that were fixed, we should note that in the comment and remind them to uplift all patches
Maybe when there are regressions that were fixed, we should note that in the comment and remind them to uplift all patches
calixteman
Mar 3, 2020
Author
Contributor
I'm not sure about the wording
I'm not sure about the wording
| "f2": self.status_beta, | ||
| "o2": "anyexact", | ||
| "v2": "affected", | ||
| # Changed before 2 days ago and not changed after 2 days ago |
jcristau
Mar 3, 2020
Contributor
Does "last resolved" not give you what you need here?
Does "last resolved" not give you what you need here?
calixteman
Mar 6, 2020
Author
Contributor
I'd say that last_resolved and this way to check are pretty similar but different.
AFAIK, cf_last_resolved is the last time that resolution is no more --- or something like that and here we check the last change on the status flag for nightly.
Anyway, I don't care so much, finally it's up to you, so what's the best option according to your needs ?
I'd say that last_resolved and this way to check are pretty similar but different.
AFAIK, cf_last_resolved is the last time that resolution is no more --- or something like that and here we check the last change on the status flag for nightly.
Anyway, I don't care so much, finally it's up to you, so what's the best option according to your needs ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.