727743 add field wiki profile #8

Merged
merged 1 commit into from Feb 21, 2012

1 participant

@ednapiranha ednapiranha commented on an outdated diff Feb 21, 2012
remo/profiles/templates/profiles_edit.html
@@ -135,7 +135,14 @@
{{ profileform.mozillians_profile_url.errors }}
</small>
{% endif %}
- <select name="mentor">
+ <input type="text" placeholder="Wiki profile" value="{{ profileform.wiki_profile_url.value }}"
@ednapiranha
Mozilla member

line up 'value' attr and the other ones below 'type'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@ednapiranha ednapiranha commented on an outdated diff Feb 21, 2012
remo/profiles/templates/profiles_view.html
@@ -297,4 +303,4 @@ <h5 class="grayed">
markers.addMarker(new OpenLayers.Marker(lonlat, icon.clone()));
markers.setOpacity(0.7);
</script>
@ednapiranha
Mozilla member

is there any way to non-inline this javascript, even if it has to be an additional js file? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@ednapiranha ednapiranha commented on an outdated diff Feb 21, 2012
media/js/profiles_view.js
+ var map = new OpenLayers.Map('map', {
+ controls: [
+ new OpenLayers.Control.Navigation(),
+ new OpenLayers.Control.ArgParser(),
+ new OpenLayers.Control.Attribution()],
+ projection: new OpenLayers.Projection('EPSG:900913')
+ });
+ var panel = new OpenLayers.Control.Panel();
+ var markers = new OpenLayers.Layer.Markers('Reps');
+ var osm = new OpenLayers.Layer.OSM();
+
+ map.addLayers([osm]);
+ map.zoomToMaxExtent();
+ map.addLayer(markers);
+
+ var lonlat = new OpenLayers.LonLat($('#map').data('lon'),
@ednapiranha
Mozilla member

one small nit! :) set $('#map') in a var so it's cached once and not called twice. e.g. var map_el = $('#map');

new OpenLayers.LonLat(map_el.data('lon') ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@glogiotatidis glogiotatidis merged commit f85f9e6 into mozilla:master Feb 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment