Handle missing db properly in test and prod. Fixes #4. #10

Merged
merged 2 commits into from Aug 6, 2013

Projects

None yet

2 participants

@6a68
Member
6a68 commented Jul 12, 2013

@jedp updated, mind merging in?

The if !db lines accommodate unit testing without redis running/installed.

Modify those lines to return 200/[] if testing, or 500 if in prod.

If we fill up the redis DB again, or it crashes or whatever, the service will stop infuriatingly telling you you've got zero emails. This is good.

@6a68
Member
6a68 commented Jul 12, 2013

Updated to add the ISO timestamps that were so incredibly helpful when debugging deployer recently.

@6a68
Member
6a68 commented Jul 12, 2013

I should add that 1/6 unit tests fails before and after this change, with redis turned off, and all tests pass before and after, with redis turned on (running on localhost).

@6a68
Member
6a68 commented Aug 6, 2013

@rfk mind a little quid pro quo review/merge action over here? ;-)

@rfk rfk merged commit 2649fbd into mozilla:master Aug 6, 2013

1 check passed

Details default The Travis CI build passed
@6a68 6a68 deleted the 6a68:nodb branch Aug 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment