Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ES6 additions to String #163

Closed
gbrail opened this issue Mar 10, 2015 · 6 comments
Closed

Support ES6 additions to String #163

gbrail opened this issue Mar 10, 2015 · 6 comments
Milestone

Comments

@gbrail
Copy link
Collaborator

gbrail commented Mar 10, 2015

These include:

startsWith
endsWith
repeat
codePointAt
normalize
includes

@eshepelyuk
Copy link
Contributor

@gbrail I've started to work on the issue, could you please assign it to me ?

@tntim96
Copy link
Contributor

tntim96 commented Apr 27, 2015

Will there be any AST changes with the implementation?

@eshepelyuk
Copy link
Contributor

Should not be any. Just injecting method to NativeString class.

@gbrail
Copy link
Collaborator Author

gbrail commented Apr 27, 2015

Officially marking you as the owner seems to be something that I need help
from the Mozilla GitHub team for because you (and a lot of people,
actually) are not part of the project.

In the meantime, we'll have to work with comments...

On Sun, Apr 26, 2015 at 10:47 PM, Evgeny Shepelyuk <notifications@github.com

wrote:

@gbrail https://github.com/gbrail I've started to work on the issue,
could you please assign it to me ?


Reply to this email directly or view it on GitHub
#163 (comment).

greg brail | apigee https://apigee.com/ | twitter @gbrail
http://twitter.com/gbrail

@eshepelyuk
Copy link
Contributor

Doest GitHub allow only colalborators to be assigned to an issue ?
No probs, if so. I'll keep working on the issue.

@gbrail
Copy link
Collaborator Author

gbrail commented Apr 27, 2015

Yes, please keep working on it -- I need to find out how to add collaborators in the "Mozilla" org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants