Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit spans in bytes!() error messages to the argument in question #9245

Closed
wants to merge 1 commit into from

Conversation

lilyball
Copy link
Contributor

This constrains the span to the appropriate argument, so you know which
one caused the problem. Instead of

foo.rs:2:4: 2:21 error: Too large integer literal in bytes!
foo.rs:2    bytes!(1, 256, 2)
            ^~~~~~~~~~~~~~~~~

it will say

foo.rs:2:14 2:17 error: Too large integer literal in bytes!
foo.rs:2    bytes!(1, 256, 2)
                      ^~~

This constrains the span to the appropriate argument, so you know which
one caused the problem. Instead of

  foo.rs:2:4: 2:21 error: Too large integer literal in bytes!
  foo.rs:2    bytes!(1, 256, 2)
              ^~~~~~~~~~~~~~~~~

it will say

  foo.rs:2:14 2:17 error: Too large integer literal in bytes!
  foo.rs:2    bytes!(1, 256, 2)
                        ^~~
bors added a commit that referenced this pull request Sep 17, 2013
This constrains the span to the appropriate argument, so you know which
one caused the problem. Instead of

    foo.rs:2:4: 2:21 error: Too large integer literal in bytes!
    foo.rs:2    bytes!(1, 256, 2)
                ^~~~~~~~~~~~~~~~~

it will say

    foo.rs:2:14 2:17 error: Too large integer literal in bytes!
    foo.rs:2    bytes!(1, 256, 2)
                          ^~~
@bors bors closed this Sep 17, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 28, 2022
…iles_on_windows, r=Alexendoo

Enable test multiple_config_files on windows

Verified that it actully works on windows
changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants