fix: Correct the GET authentication for S3 using rusoto #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marwes
force-pushed
the
rusoto
branch
3 times, most recently
from
9c766e1
to
6cf2ac6
Compare
|
Rebased and moved up contained all accidental formatting into the first commit (see #502 ). https://github.com/mozilla/sccache/pull/471/files/dfe5f403dde8f56c24dd2a03acafa6cfaa378dcc..6cf2ac66baba83ebc28a97ba0e24820bf91e634d gives the actual changes which should be much simpler to review. |
added 22 commits
August 27, 2019 11:23
Carefully downgrades tiny_http to still use the patched version
The patch got merge under a different issue
added 8 commits
August 27, 2019 11:38
For some unknown reason authenticated GET accesses fails under certain configurations. So far I have been unable to determine the exact cause but after adding `rusoto_s3` to deal with all communication to S3 it fixed itself so at least for my case this would be a good fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some unknown reason authenticated GET accesses fails under certain
configurations. So far I have been unable to determine the exact cause
but after adding
rusoto_s3to deal with all communication to S3 itfixed itself so at least for my case this would be a good fix.
I wasn't sure exactly what to do about the config file format as that probably needs to change to better fit what rusoto accepts. At least it should be expanded to support reading in the region which currently only seems to work through an environment variable.
Based on #470 since that fixes some build errors for me.
Closes #337