Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Thunderbird #496

Closed
MikkCZ opened this issue Aug 10, 2017 · 8 comments
Closed

Add support for Thunderbird #496

MikkCZ opened this issue Aug 10, 2017 · 8 comments

Comments

@MikkCZ
Copy link
Contributor

@MikkCZ MikkCZ commented Aug 10, 2017

Thunderbird is still in the Mozilla family. It would be nice to have Send as an option for sending large files, IMO preferably as an add-on, so we do not have to wait until next Thunderbird release. ;)

@ehuggett

This comment has been minimized.

Copy link
Contributor

@ehuggett ehuggett commented Aug 14, 2017

Great idea, not always suitable for email but if you know the receiver is waiting for the file it could be very useful indeed.

#403 is somewhat related as Mozilla Thunderbird would be an excellent example of where it is not nessisary (and safer not to) execute JavaScript from Send. If both parties have a plugin, they only need the encrypted data itself. If the receiver does not have the plug-in, thunderbird would pass the url to a browser as normal.

But this would Rely on Send presenting a stable interface, so the plug-in does not need constant updates to function (a simple method to determine the "protocol version" would at least allow the plugin to tell the user it needs updating, even if no update plugin has been written)... but perhaps it will be "stable enough" without this once the current "rush" of idea's and changes ends.

@ehuggett

This comment has been minimized.

Copy link
Contributor

@ehuggett ehuggett commented Aug 14, 2017

related, probably a requirement (a stable interface) #431

@wresuolc wresuolc added this to the Stretch milestone Aug 16, 2017
@ehuggett

This comment has been minimized.

Copy link
Contributor

@ehuggett ehuggett commented Aug 20, 2017

https://support.mozilla.org/en-US/kb/filelink-large-attachments

two examples
https://github.com/meganz/filelink (MPL v2)
https://github.com/DownloadTicketService/dl/tree/master/client/thunderbird-filelink-dl (GPL v2)

Should the plugin also prompt to download send urls? Supporting privately hosted Sends would not be impossible but probably can't guarantee no false positives (http or https, hostname or ip or ip+port and it may not be on the root of the domain)

\/download\/[0-9a-f]{10}\/#[a-zA-Z\d-_]{22}$

How would non-english language support be handled? (can any the current strings in Send be reused?)

Not quite off topic(?): A Firefox addon would also have some benefits, I believe addons can 'hijack' urls (ie uBlocks strict blocking) which would make it possible to 'override' the entire send domain and replace it with a upload/download interface from the local addon? (anyone know how this would interact with the noscript addon, would it still need whitelisting?)

@ehuggett

This comment has been minimized.

Copy link
Contributor

@ehuggett ehuggett commented Jan 30, 2018

Thunderbird does not yet support webextensions https://bugzilla.mozilla.org/show_bug.cgi?id=1396172 but it does not seem that there are currently any plans to remove support for current extensions either

@dannycoates dannycoates modified the milestones: Stretch, back burner Mar 2, 2018
@wresuolc

This comment has been minimized.

Copy link
Collaborator

@wresuolc wresuolc commented May 10, 2018

Thanks for filing this, but we have no plans to work on this in the near future.

@wresuolc wresuolc closed this May 10, 2018
@marco-c

This comment has been minimized.

Copy link

@marco-c marco-c commented May 10, 2018

@wresuolc would you accept community contributions for this?

@fzzzy

This comment has been minimized.

Copy link
Collaborator

@fzzzy fzzzy commented May 10, 2018

@marco-c Isn't the actual issue that Thunderbird does not support WebExtensions? That needs to happen first.

@kewisch

This comment has been minimized.

Copy link

@kewisch kewisch commented Jan 8, 2019

Thunderbird supports WebExtensions now, and if there is anything missing we are happy to add the neccessary APIs. From a brief read though I am not sure what specific WebExtension APIs are necessary? It seems to me that all that would be needed is WebCrypto and fetch/xhr. For adding a filelink provider there is an API available in Thunderbird.

If there is any guidance on how to programmatically send files to the API that would be a good start. It seems that some of the source code from send/app/ could be re-used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.