Skip to content

/send

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hack the favicon to show visual progress #803

Open
ryanfeeley opened this issue Apr 11, 2018 · 7 comments · May be fixed by #1269
Open

Hack the favicon to show visual progress #803

ryanfeeley opened this issue Apr 11, 2018 · 7 comments · May be fixed by #1269
Labels
good first issue skill:js
Milestone
Stretch 🙆‍♀️

Comments

@ryanfeeley
Copy link

@ryanfeeley ryanfeeley commented Apr 11, 2018

Not a complete design but ever consider replicating your upload progress in the favicon?
Relevant pieces:
screen shot 2018-04-07 at 6 19 05 pm screen shot 2018-04-07 at 6 18 53 pm
screen shot 2018-04-07 at 6 19 10 pm
@wresuolc wresuolc added this to the Stretch 🙆‍♀️ milestone May 10, 2018
@KancerEzeroglu

This comment has been minimized.

Sign in to view
Copy link

@KancerEzeroglu KancerEzeroglu commented May 28, 2018

Hi @wresuolc, if anyone else does not work on this issue, can I try?
@marniepw

This comment has been minimized.

Sign in to view
Copy link

@marniepw marniepw commented May 29, 2018

@KancerEzeroglu go for it!
@KancerEzeroglu

This comment has been minimized.

Sign in to view
Copy link

@KancerEzeroglu KancerEzeroglu commented May 29, 2018

I will @marniepw 😊
@KancerEzeroglu

This comment has been minimized.

Sign in to view
Copy link

@KancerEzeroglu KancerEzeroglu commented Jun 1, 2018 •
edited

Hi @marniepw , can I use external library for issue? Like: https://github.com/lipka/piecon or http://nicolasbize.com/faviconx/
@marniepw

This comment has been minimized.

Sign in to view
Copy link

@marniepw marniepw commented Jun 1, 2018

I'm not 100% sure, so I'd like @dannycoates to weigh in here.
KancerEzeroglu added a commit to KancerEzeroglu/send that referenced this issue Jun 2, 2018
@KancerEzeroglu
The logic for updating title was already implemented. I fixed wrong e…
dd7f04b 
…vent listeners. related mozilla#803
@KancerEzeroglu KancerEzeroglu mentioned this issue Jun 2, 2018
Closed
@arealdeadone

This comment has been minimized.

Sign in to view
Copy link

@arealdeadone arealdeadone commented Dec 20, 2018

Hi is this issue still open for someone to work on?
@asheshvidyut7 asheshvidyut7 mentioned this issue Mar 20, 2019
Open
@asheshvidyut7

This comment has been minimized.

Sign in to view
Copy link

@asheshvidyut7 asheshvidyut7 commented Mar 20, 2019

Hi,
Created a pull request #1269.
Please review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue skill:js
Projects
None yet
Milestone
  Stretch 🙆‍♀️
6 participants
@ryanfeeley @KancerEzeroglu @marniepw @arealdeadone @asheshvidyut7 @wresuolc
You can’t perform that action at this time.