Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update android port to be available #1445

Merged
merged 11 commits into from Jan 3, 2014
Merged

update android port to be available #1445

merged 11 commits into from Jan 3, 2014

Conversation

aydinkim
Copy link

  1. We've aimed to android 4.3 Jellybean devices like Galaxy 10.1 and Galaxy Nexus, etc. I think it could still support android 4.1
  2. Needs android ndk r9(not r9b) and latest android sdk
  3. Needs some device list update on sdk for apk build.
  4. Currently we can not build android port on mac because compiler build problem like Upgrade libuv with an OSX build system fix rust-lang/rust#10921. Hopefully I expect that it could be resolved at next rust upgrade.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/494

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@newchief newchief mentioned this pull request Dec 31, 2013
Closed
@kmcallister
Copy link
Contributor

Nice! I'm reviewing this now.

@kmcallister
Copy link
Contributor

I'm ready to sign off on this once there's a commit to touch rust-auto-clean-trigger.

@aydinkim
Copy link
Author

aydinkim commented Jan 2, 2014

Ok! Within 15 min, I can do that.

bors-servo pushed a commit that referenced this pull request Jan 2, 2014
auto merge of #1445 : webconv/servo/PR_android, r=kmcallister
c52edec 
1. We've aimed to android 4.3 Jellybean devices like Galaxy 10.1 and Galaxy Nexus, etc. I think it could still support android 4.1
2. Needs android ndk r9(not r9b) and latest android sdk
3. Needs some device list update on sdk for apk build.
4. Currently we can not build android port on mac because compiler build problem like rust-lang/rust#10921. Hopefully I expect that it could be resolved at next rust upgrade.
bors-servo pushed a commit that referenced this pull request Jan 3, 2014
auto merge of #1445 : webconv/servo/PR_android, r=kmcallister
c7b3eeb 
1. We've aimed to android 4.3 Jellybean devices like Galaxy 10.1 and Galaxy Nexus, etc. I think it could still support android 4.1
2. Needs android ndk r9(not r9b) and latest android sdk
3. Needs some device list update on sdk for apk build.
4. Currently we can not build android port on mac because compiler build problem like rust-lang/rust#10921. Hopefully I expect that it could be resolved at next rust upgrade.
bors-servo pushed a commit that referenced this pull request Jan 3, 2014
auto merge of #1445 : webconv/servo/PR_android, r=kmcallister
bc56d96 
1. We've aimed to android 4.3 Jellybean devices like Galaxy 10.1 and Galaxy Nexus, etc. I think it could still support android 4.1
2. Needs android ndk r9(not r9b) and latest android sdk
3. Needs some device list update on sdk for apk build.
4. Currently we can not build android port on mac because compiler build problem like rust-lang/rust#10921. Hopefully I expect that it could be resolved at next rust upgrade.
@aydinkim
Copy link
Author

aydinkim commented Jan 3, 2014

We need to entirely clean the submodule - servo-android-glue.
I think it would be succeeded after then.
Are there anybody who can do it?

bors-servo pushed a commit that referenced this pull request Jan 3, 2014
auto merge of #1445 : webconv/servo/PR_android, r=kmcallister
0555b8c 
1. We've aimed to android 4.3 Jellybean devices like Galaxy 10.1 and Galaxy Nexus, etc. I think it could still support android 4.1
2. Needs android ndk r9(not r9b) and latest android sdk
3. Needs some device list update on sdk for apk build.
4. Currently we can not build android port on mac because compiler build problem like rust-lang/rust#10921. Hopefully I expect that it could be resolved at next rust upgrade.
bors-servo pushed a commit that referenced this pull request Jan 3, 2014
auto merge of #1445 : webconv/servo/PR_android, r=kmcallister
90f4473 
1. We've aimed to android 4.3 Jellybean devices like Galaxy 10.1 and Galaxy Nexus, etc. I think it could still support android 4.1
2. Needs android ndk r9(not r9b) and latest android sdk
3. Needs some device list update on sdk for apk build.
4. Currently we can not build android port on mac because compiler build problem like rust-lang/rust#10921. Hopefully I expect that it could be resolved at next rust upgrade.
@bors-servo bors-servo closed this Jan 3, 2014
@bors-servo bors-servo merged commit f2f9084 into servo:master Jan 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aydinkim @hoppipolla-critic-bot @highfive @kmcallister @bors-servo