Skip to content

Refactoring/reformatting interpretActions #1187

Merged
merged 2 commits into from Mar 8, 2014

3 participants

@yurydelendik

No description provided.

@yurydelendik

/botio reftest

@shumwaybot

From: Bot.io (Main)


Received

Command cmd_reftest from @yurydelendik received. Current queue size: 0

Live output at: http://areweflashyet.com:8081/6d1fe7c13939201/output.txt

@shumwaybot

From: Bot.io (Main)


Failed

Full output at http://areweflashyet.com:8081/6d1fe7c13939201/output.txt

Total script time: 4.72 mins

  • Lint: Passed

  • Reference tests: FAILED

TEST-UNEXPECTED-FAIL | stas button | in chrome-ish | trace of 1 != reference trace
TEST-UNEXPECTED-FAIL | stas 3_joystick | in chrome-ish | trace of 1 != reference trace
TEST-UNEXPECTED-FAIL | stas timeline_scene | in chrome-ish | trace of 4 != reference trace
TEST-UNEXPECTED-FAIL | stas timeline_scene | in chrome-ish | trace of 6 != reference trace
TEST-UNEXPECTED-FAIL | stas timeline_scene | in firefox | trace of 6 != reference trace

@yurydelendik yurydelendik merged commit 0ded13e into mozilla:master Mar 8, 2014
@yurydelendik yurydelendik deleted the yurydelendik:avm1ref branch Mar 8, 2014
@mbebenita mbebenita commented on the diff Mar 8, 2014
src/avm1/interpreter.js
}
}
}
-}
+
+ function interpretActions(actionsData, scopeContainer, constantPool, registers) {
+ var currentContext = AS2Context.instance;
+
+ var stream = new ActionsDataStream(actionsData, currentContext.swfVersion);
+ var stack = [];
+ var isSwfVersion5 = currentContext.swfVersion >= 5;
+ var actionTracer = ActionTracerFactory.get();
+ var scope = scopeContainer.scope;
+
+ var executionContext = {
@mbebenita
mbebenita added a note Mar 8, 2014

Why not just context? So you don't have to use ectx instead of ctx which is more common.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@yurydelendik

No reason. ctx sounded as bad as ectx. It's temporary refactoring, in the future this might change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.