New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fontfixes #1321

Closed
wants to merge 17 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@rszaloki
Contributor

rszaloki commented May 26, 2014

Improves font and label rendering.

If a swf generated by a converter (eg: pdf to swf), then sometimes the converter cannot create a valid font information. Also the "text" label shouldn't flip vertically, but the text2 should.

@tschneidereit

This comment has been minimized.

Show comment
Hide comment
@tschneidereit

tschneidereit May 26, 2014

Member

Hey @rszaloki, thanks a lot of this and the other fixes you've submitted.

Unfortunately, while we can apply them, they won't be useful for that long anymore: we're working on a huge refactoring of the entire code base in the nat branch. Almost all code is or will be ported to TypeScript, and the entire code organization is very different.

I'm truly sorry about us causing this situation. If you're up for it, contributions to that branch would be very welcome. Join us in the shumway IRC channel on irc.mozilla.org to learn more about that. Otherwise, we'll take your patches and apply the fixes to the nat branch.

Member

tschneidereit commented May 26, 2014

Hey @rszaloki, thanks a lot of this and the other fixes you've submitted.

Unfortunately, while we can apply them, they won't be useful for that long anymore: we're working on a huge refactoring of the entire code base in the nat branch. Almost all code is or will be ported to TypeScript, and the entire code organization is very different.

I'm truly sorry about us causing this situation. If you're up for it, contributions to that branch would be very welcome. Join us in the shumway IRC channel on irc.mozilla.org to learn more about that. Otherwise, we'll take your patches and apply the fixes to the nat branch.

@rszaloki

This comment has been minimized.

Show comment
Hide comment
@rszaloki

rszaloki May 26, 2014

Contributor

Hi,

I tried the channel, but no one responded, so maybe in email :)

I took a look on the nat branch and IMHO you can apply the fixes on it.
Should I make the changes on the nat branch and issue a another pull
requests? If I should, then how can I test it? I tried to build it, but I
didn't had any luck, then I tried to use the inspector but it throws a lots
of error.

thanks,
robert

On Mon, May 26, 2014 at 3:57 PM, Till Schneidereit <notifications@github.com

wrote:

Hey @rszaloki https://github.com/rszaloki, thanks a lot of this and the
other fixes you've submitted.

Unfortunately, while we can apply them, they won't be useful for that long
anymore: we're working on a huge refactoring of the entire code base in the
nat branch http://../tree/nat. Almost all code is or will be ported to
TypeScript, and the entire code organization is very different.

I'm truly sorry about us causing this situation. If you're up for it,
contributions to that branch would be very welcome. Join us in the shumway
IRC channel on irc.mozilla.org to learn more about that. Otherwise, we'll
take your patches and apply the fixes to the nat branch.


Reply to this email directly or view it on GitHubhttps://github.com/mozilla/shumway/pull/1321#issuecomment-44191186
.

Contributor

rszaloki commented May 26, 2014

Hi,

I tried the channel, but no one responded, so maybe in email :)

I took a look on the nat branch and IMHO you can apply the fixes on it.
Should I make the changes on the nat branch and issue a another pull
requests? If I should, then how can I test it? I tried to build it, but I
didn't had any luck, then I tried to use the inspector but it throws a lots
of error.

thanks,
robert

On Mon, May 26, 2014 at 3:57 PM, Till Schneidereit <notifications@github.com

wrote:

Hey @rszaloki https://github.com/rszaloki, thanks a lot of this and the
other fixes you've submitted.

Unfortunately, while we can apply them, they won't be useful for that long
anymore: we're working on a huge refactoring of the entire code base in the
nat branch http://../tree/nat. Almost all code is or will be ported to
TypeScript, and the entire code organization is very different.

I'm truly sorry about us causing this situation. If you're up for it,
contributions to that branch would be very welcome. Join us in the shumway
IRC channel on irc.mozilla.org to learn more about that. Otherwise, we'll
take your patches and apply the fixes to the nat branch.


Reply to this email directly or view it on GitHubhttps://github.com/mozilla/shumway/pull/1321#issuecomment-44191186
.

@mbebenita

This comment has been minimized.

Show comment
Hide comment
@mbebenita

mbebenita May 26, 2014

Contributor

Hi Robert,

Great set of patches. Although we've migrated a lot of the code to TypeScript the /swf module hasn't been migrated so I think these patches should be able to land safely. /ccing @yurydelendik & @tobytailor for review.

The new nat branch attempts to split SWF execution from rendering and is not completely wired up. Once that's ready you'll be able to test your changes. I foresee that happening relatively soon.

Contributor

mbebenita commented May 26, 2014

Hi Robert,

Great set of patches. Although we've migrated a lot of the code to TypeScript the /swf module hasn't been migrated so I think these patches should be able to land safely. /ccing @yurydelendik & @tobytailor for review.

The new nat branch attempts to split SWF execution from rendering and is not completely wired up. Once that's ready you'll be able to test your changes. I foresee that happening relatively soon.

@rszaloki

This comment has been minimized.

Show comment
Hide comment
@rszaloki

rszaloki May 27, 2014

Contributor

Hi Michael,

This is a really good news, thanks! Also the split of the execution and the
rendering is a very welcome change, because I have more changes, which are
implementing this kind of behavior, but I think it's best to have it done
from the ground.

Robert

On Mon, May 26, 2014 at 8:03 PM, Michael Bebenita
notifications@github.comwrote:

Hi Robert,

Great set of patches. Although we've migrated a lot of the code to
TypeScript the /swf module hasn't been migrated so I think these patches
should be able to land safely. /ccing @yurydelendikhttps://github.com/yurydelendik&
@tobytailor https://github.com/tobytailor for review.

The new nat branch attempts to split SWF execution from rendering and is
not completely wired up. Once that's ready you'll be able to test your
changes. I foresee that happening relatively soon.


Reply to this email directly or view it on GitHubhttps://github.com/mozilla/shumway/pull/1321#issuecomment-44208132
.

Contributor

rszaloki commented May 27, 2014

Hi Michael,

This is a really good news, thanks! Also the split of the execution and the
rendering is a very welcome change, because I have more changes, which are
implementing this kind of behavior, but I think it's best to have it done
from the ground.

Robert

On Mon, May 26, 2014 at 8:03 PM, Michael Bebenita
notifications@github.comwrote:

Hi Robert,

Great set of patches. Although we've migrated a lot of the code to
TypeScript the /swf module hasn't been migrated so I think these patches
should be able to land safely. /ccing @yurydelendikhttps://github.com/yurydelendik&
@tobytailor https://github.com/tobytailor for review.

The new nat branch attempts to split SWF execution from rendering and is
not completely wired up. Once that's ready you'll be able to test your
changes. I foresee that happening relatively soon.


Reply to this email directly or view it on GitHubhttps://github.com/mozilla/shumway/pull/1321#issuecomment-44208132
.

@tschneidereit

This comment has been minimized.

Show comment
Hide comment
@tschneidereit

tschneidereit May 27, 2014

Member

Hey Robert,

you should be able to test your changes to at least some extent by running
npm install in your checkout to get all the dependencies, and then grunt player to compile the TypeScript code. After that, you can run grunt server and access the inspector via
http://localhost:8000/examples/inspector/inspector.html. Adding an rfile
argument to the url lets you load a SWF directly:
http://localhost:8000/examples/inspector/inspector.html?rfile=../racing/race3.swf

Member

tschneidereit commented May 27, 2014

Hey Robert,

you should be able to test your changes to at least some extent by running
npm install in your checkout to get all the dependencies, and then grunt player to compile the TypeScript code. After that, you can run grunt server and access the inspector via
http://localhost:8000/examples/inspector/inspector.html. Adding an rfile
argument to the url lets you load a SWF directly:
http://localhost:8000/examples/inspector/inspector.html?rfile=../racing/race3.swf

@rszaloki

This comment has been minimized.

Show comment
Hide comment
@rszaloki

rszaloki May 27, 2014

Contributor

Hey Till,

I tried grunt player, but it aborts with this:
Running "exec:build_player_ts" (exec) task

/home/robi/shumway/src/avm2/references.ts(39,1): error TS5007: Cannot
resolve referenced file: 'natives/genericVector.ts'.
/home/robi/shumway/src/avm2/references.ts(51,1): error TS5007: Cannot
resolve referenced file: 'compiler/c4/back.ts'.
/home/robi/shumway/src/avm2/native.ts(1433,56): error TS2095: Could not
find symbol 'GenericVector'.
Exited with code: 1.
Warning: Task "exec:build_player_ts" failed. Use --force to continue.

Aborted due to warnings.

Is it just me or should I wait for some updates?

Thanks,
Robert

On Tue, May 27, 2014 at 11:43 AM, Till Schneidereit <
notifications@github.com> wrote:

Hey Robert,

you should be able to test your changes to at least some extent by running
npm install in your checkout to get all the dependencies, and then
grunt player to compile the TypeScript code. After that, you can run grunt server and access the inspector via
http://localhost:8000/examples/inspector/inspector.html. Adding an
rfile
argument to the url lets you load a SWF directly:

http://localhost:8000/examples/inspector/inspector.html?rfile=../racing/race3.swf
.

On Tue, May 27, 2014 at 11:02 AM, rszaloki notifications@github.com
wrote:

Hi Michael,

This is a really good news, thanks! Also the split of the execution and
the
rendering is a very welcome change, because I have more changes, which
are
implementing this kind of behavior, but I think it's best to have it
done
from the ground.

Robert

On Mon, May 26, 2014 at 8:03 PM, Michael Bebenita
notifications@github.comwrote:

Hi Robert,

Great set of patches. Although we've migrated a lot of the code to
TypeScript the /swf module hasn't been migrated so I think these
patches
should be able to land safely. /ccing @yurydelendik<
https://github.com/yurydelendik>&
@tobytailor https://github.com/tobytailor for review.

The new nat branch attempts to split SWF execution from rendering and
is
not completely wired up. Once that's ready you'll be able to test your
changes. I foresee that happening relatively soon.


Reply to this email directly or view it on GitHub<
https://github.com/mozilla/shumway/pull/1321#issuecomment-44208132>
.


Reply to this email directly or view it on GitHub<
https://github.com/mozilla/shumway/pull/1321#issuecomment-44250997>
.


Reply to this email directly or view it on GitHubhttps://github.com/mozilla/shumway/pull/1321#issuecomment-44254547
.

Contributor

rszaloki commented May 27, 2014

Hey Till,

I tried grunt player, but it aborts with this:
Running "exec:build_player_ts" (exec) task

/home/robi/shumway/src/avm2/references.ts(39,1): error TS5007: Cannot
resolve referenced file: 'natives/genericVector.ts'.
/home/robi/shumway/src/avm2/references.ts(51,1): error TS5007: Cannot
resolve referenced file: 'compiler/c4/back.ts'.
/home/robi/shumway/src/avm2/native.ts(1433,56): error TS2095: Could not
find symbol 'GenericVector'.
Exited with code: 1.
Warning: Task "exec:build_player_ts" failed. Use --force to continue.

Aborted due to warnings.

Is it just me or should I wait for some updates?

Thanks,
Robert

On Tue, May 27, 2014 at 11:43 AM, Till Schneidereit <
notifications@github.com> wrote:

Hey Robert,

you should be able to test your changes to at least some extent by running
npm install in your checkout to get all the dependencies, and then
grunt player to compile the TypeScript code. After that, you can run grunt server and access the inspector via
http://localhost:8000/examples/inspector/inspector.html. Adding an
rfile
argument to the url lets you load a SWF directly:

http://localhost:8000/examples/inspector/inspector.html?rfile=../racing/race3.swf
.

On Tue, May 27, 2014 at 11:02 AM, rszaloki notifications@github.com
wrote:

Hi Michael,

This is a really good news, thanks! Also the split of the execution and
the
rendering is a very welcome change, because I have more changes, which
are
implementing this kind of behavior, but I think it's best to have it
done
from the ground.

Robert

On Mon, May 26, 2014 at 8:03 PM, Michael Bebenita
notifications@github.comwrote:

Hi Robert,

Great set of patches. Although we've migrated a lot of the code to
TypeScript the /swf module hasn't been migrated so I think these
patches
should be able to land safely. /ccing @yurydelendik<
https://github.com/yurydelendik>&
@tobytailor https://github.com/tobytailor for review.

The new nat branch attempts to split SWF execution from rendering and
is
not completely wired up. Once that's ready you'll be able to test your
changes. I foresee that happening relatively soon.


Reply to this email directly or view it on GitHub<
https://github.com/mozilla/shumway/pull/1321#issuecomment-44208132>
.


Reply to this email directly or view it on GitHub<
https://github.com/mozilla/shumway/pull/1321#issuecomment-44250997>
.


Reply to this email directly or view it on GitHubhttps://github.com/mozilla/shumway/pull/1321#issuecomment-44254547
.

@tschneidereit

This comment has been minimized.

Show comment
Hide comment
@tschneidereit

tschneidereit May 27, 2014

Member

Hey Robert,

ah, the problem is that the Shumway core team members all develop on OS X,
where the filesystem by default is case-insensitive. I fixed
avm2/references.ts to refer to GenericVector.ts instead of
genericVector.ts. The missing reference to compiler/c4/back.ts has been
fixed a few commits ago, so if you pull in the current version, your build
should succeed.

Member

tschneidereit commented May 27, 2014

Hey Robert,

ah, the problem is that the Shumway core team members all develop on OS X,
where the filesystem by default is case-insensitive. I fixed
avm2/references.ts to refer to GenericVector.ts instead of
genericVector.ts. The missing reference to compiler/c4/back.ts has been
fixed a few commits ago, so if you pull in the current version, your build
should succeed.

@tobytailor

This comment has been minimized.

Show comment
Hide comment
@tobytailor

tobytailor May 29, 2014

Contributor

@rszaloki do you have a test SWF for this? Would like to merge this PR into the nat branch.

Contributor

tobytailor commented May 29, 2014

@rszaloki do you have a test SWF for this? Would like to merge this PR into the nat branch.

@rszaloki

This comment has been minimized.

Show comment
Hide comment
@rszaloki

rszaloki May 29, 2014

Contributor

yes, I will send it tomorrow
On May 29, 2014 7:58 PM, "Tobias Schneider" notifications@github.com
wrote:

@rszaloki https://github.com/rszaloki do you have a test SWF for this?
Would like to merge this PR into the nat branch.


Reply to this email directly or view it on GitHubhttps://github.com/mozilla/shumway/pull/1321#issuecomment-44562975
.

Contributor

rszaloki commented May 29, 2014

yes, I will send it tomorrow
On May 29, 2014 7:58 PM, "Tobias Schneider" notifications@github.com
wrote:

@rszaloki https://github.com/rszaloki do you have a test SWF for this?
Would like to merge this PR into the nat branch.


Reply to this email directly or view it on GitHubhttps://github.com/mozilla/shumway/pull/1321#issuecomment-44562975
.

@rszaloki

This comment has been minimized.

Show comment
Hide comment
@rszaloki

rszaloki May 30, 2014

Contributor

I'm sorry, but for this we used a non public test swf, but we are working
on to find a public one.

On Thu, May 29, 2014 at 8:06 PM, Robert Szaloki r.szaloki@gmail.com wrote:

yes, I will send it tomorrow
On May 29, 2014 7:58 PM, "Tobias Schneider" notifications@github.com
wrote:

@rszaloki https://github.com/rszaloki do you have a test SWF for this?
Would like to merge this PR into the nat branch.


Reply to this email directly or view it on GitHub
#1321 (comment).

Contributor

rszaloki commented May 30, 2014

I'm sorry, but for this we used a non public test swf, but we are working
on to find a public one.

On Thu, May 29, 2014 at 8:06 PM, Robert Szaloki r.szaloki@gmail.com wrote:

yes, I will send it tomorrow
On May 29, 2014 7:58 PM, "Tobias Schneider" notifications@github.com
wrote:

@rszaloki https://github.com/rszaloki do you have a test SWF for this?
Would like to merge this PR into the nat branch.


Reply to this email directly or view it on GitHub
#1321 (comment).

@rszaloki

This comment has been minimized.

Show comment
Hide comment
@tobytailor

This comment has been minimized.

Show comment
Hide comment
@tobytailor

tobytailor Jun 9, 2014

Contributor

/botio test

Contributor

tobytailor commented Jun 9, 2014

/botio test

@shumwaybot

This comment has been minimized.

Show comment
Hide comment
@shumwaybot

shumwaybot Jun 9, 2014

From: Bot.io (Main)


Received

Command cmd_test from @tobytailor received. Current queue size: 0

Live output at: http://areweflashyet.com:8081/199ce6b2ad3e7f3/output.txt

shumwaybot commented Jun 9, 2014

From: Bot.io (Main)


Received

Command cmd_test from @tobytailor received. Current queue size: 0

Live output at: http://areweflashyet.com:8081/199ce6b2ad3e7f3/output.txt

@shumwaybot

This comment has been minimized.

Show comment
Hide comment
@shumwaybot

shumwaybot Jun 9, 2014

From: Bot.io (Main)


Failed

Full output at http://areweflashyet.com:8081/199ce6b2ad3e7f3/output.txt

Total script time: 19.08 mins

shumwaybot commented Jun 9, 2014

From: Bot.io (Main)


Failed

Full output at http://areweflashyet.com:8081/199ce6b2ad3e7f3/output.txt

Total script time: 19.08 mins

@tobytailor tobytailor referenced this pull request Jul 28, 2014

Merged

Misc font fixes #1513

@mbebenita

This comment has been minimized.

Show comment
Hide comment
@mbebenita

mbebenita Apr 24, 2015

Contributor

@tobytailor are there fixes here we still need to cherrypick?

Contributor

mbebenita commented Apr 24, 2015

@tobytailor are there fixes here we still need to cherrypick?

@tobytailor

This comment has been minimized.

Show comment
Hide comment
@tobytailor

tobytailor Apr 24, 2015

Contributor

Nope, everything should already be fixed in master.

Contributor

tobytailor commented Apr 24, 2015

Nope, everything should already be fixed in master.

@tobytailor tobytailor closed this Apr 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment