Lots of fixes, compiler updates, trying to get youtube to work. #212

Merged
merged 22 commits into from Apr 6, 2013

Conversation

Projects
None yet
3 participants
Contributor

mbebenita commented Apr 6, 2013

No description provided.

Contributor

mbebenita commented Apr 6, 2013

/botio test

From: Bot.io (Main)


Received

Command cmd_test from @mbebenita received. Current queue size: 0

Live output at: http://areweflashyet.com:8081/0bd6d5bfffb974e/output.txt

Contributor

mbebenita commented Apr 6, 2013

/botio test

From: Bot.io (Main)


Received

Command cmd_test from @mbebenita received. Current queue size: 0

Live output at: http://areweflashyet.com:8081/c0b6d2595f0ac34/output.txt

Shouldn't this probably be under a debug flag?

Owner

mbebenita replied Apr 6, 2013

This is only used as an utility to dump out which methods are native in the same format as the Flash tracing tool

Ah, OK.

Do we define print in a browser context?

Owner

mbebenita replied Apr 6, 2013

what can we infer from setters?

whoops, I misread the code here.

From: Bot.io (Main)


Success

Full output at http://areweflashyet.com:8081/c0b6d2595f0ac34/output.txt

Total script time: 3.71 mins

  • Reference tests: Passed
  • AVM2 tests: Passed

magcius commented on 5aa1011 Apr 6, 2013

Sorry if I ask, but what does the compat mode do?

Owner

mbebenita replied Apr 6, 2013

Being 100% correct can cause performance problems. The idea is to relax some of the semantics with compatibility flag.

magcius commented on c2db1a5 Apr 6, 2013

Perhaps you should commit the config file? I don't see anything that generates it.

Typo in commit message as well.

Unrelated?

Squash with the original change.

getAbsolutePath is defined as getAbsolutePath(path, name) but it's being used here as getAbsolutePath(name, path). Perhaps you should just inline it? It's not really a complex function.

magcius commented on e3031fb Apr 6, 2013

You didn't add proxy.js?

Owner

mbebenita replied Apr 6, 2013

Thx, I missed it.

Contributor

mbebenita commented Apr 6, 2013

/botio test

From: Bot.io (Main)


Received

Command cmd_test from @mbebenita received. Current queue size: 0

Live output at: http://areweflashyet.com:8081/f8d099decd10c99/output.txt

From: Bot.io (Main)


Success

Full output at http://areweflashyet.com:8081/f8d099decd10c99/output.txt

Total script time: 2.18 mins

  • Reference tests: Passed
  • AVM2 tests: Passed

@mbebenita mbebenita added a commit that referenced this pull request Apr 6, 2013

@mbebenita mbebenita Merge pull request #212 from mbebenita/master
Lots of fixes, compiler updates, trying to get youtube to work.
fda35bb

@mbebenita mbebenita merged commit fda35bb into mozilla:master Apr 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment