Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

parser unquoted attributes too? #15

Pomax opened this Issue Apr 18, 2012 · 1 comment


None yet
2 participants

Pomax commented Apr 18, 2012

Not sure how prevalent this is in the wild, but we may need to support this for page remixing. It might actually not be too much work.

True dat, though for now I'd like to see if the learning team (or user testing) raises concerns about this, like they did w/ self-closing void tags in #23. I honestly didn't know that unquoted attributes were even legal until a few months ago--though my main concern with adding support for this is just that we may end up providing more confusing help to users if we assume this. For instance, HTML like this:

<p class=super cool>hi there</p>

might get successfully parsed without raising any red flags to the user (leaving them to get confused later when their CSS doesn't apply), or it might provide the unhelpful suggestion that cool is an unrecognized boolean attribute, while in fact the suggestion that the user probably needs is that they need to put quotes around their attribute value--which is what our parser currently suggests.

@Pomax Pomax closed this Dec 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment