early pull request for updated slowparse/errors #16

Merged
merged 4 commits into from Apr 20, 2012

Conversation

Projects
None yet
2 participants
@Pomax
Collaborator

Pomax commented Apr 20, 2012

to prevent a similar situation later =)

  • better CSS error reporting
  • human readable error messages for the CSS errors
  • source documentation

Mike Kamermans added some commits Apr 20, 2012

Mike Kamermans
updated slowparse with much better CSS error reporting, and source do…
…cumentation. still need to update the spec/unit tests
@toolness

This comment has been minimized.

Show comment Hide comment
@toolness

toolness Apr 20, 2012

Should we mention something about the DOMBuilder and parseInfo property here, or just point them to the README?

Should we mention something about the DOMBuilder and parseInfo property here, or just point them to the README?

@toolness

This comment has been minimized.

Show comment Hide comment
@toolness

toolness Apr 20, 2012

Minor typo, untill -> until

Minor typo, untill -> until

@toolness

This comment has been minimized.

Show comment Hide comment
@toolness

toolness Apr 20, 2012

Minor typo, HTLM -> HTML

Minor typo, HTLM -> HTML

@toolness

This comment has been minimized.

Show comment Hide comment
@toolness

toolness Apr 20, 2012

Client code generally won't need the Stream class, but we do want to unit test it, which is why this was exposed... maybe we should expose a Slowparse._testing object off of which these kinds of things should be exposed?

Client code generally won't need the Stream class, but we do want to unit test it, which is why this was exposed... maybe we should expose a Slowparse._testing object off of which these kinds of things should be exposed?

@toolness

This comment has been minimized.

Show comment Hide comment
@toolness

toolness Apr 20, 2012

Awesome. I wonder if we should use docco for these docs?

Awesome. I wonder if we should use docco for these docs?

@toolness

This comment has been minimized.

Show comment Hide comment
@toolness

toolness Apr 20, 2012

Hmm, the fact that you're not removing anything from token.interval.end suggests that this interval might contain extra whitespace...

Hmm, the fact that you're not removing anything from token.interval.end suggests that this interval might contain extra whitespace...

toolness added a commit that referenced this pull request Apr 20, 2012

Merge pull request #16 from Pomax/gh-pages
early pull request for updated slowparse/errors

@toolness toolness merged commit 3695ce0 into mozilla:gh-pages Apr 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment