Skip to content
This repository

popup windows should not have sidebar #4

Closed
michaelrhanson opened this Issue March 14, 2012 · 4 comments

3 participants

Michael Hanson Mark Hammond Shane Caraveo
Michael Hanson
Collaborator

We should determine when a window.open call is intended to create a "popup" window, and not insert the sidebar in this case. At a minimum, the absence of the "toolbar" feature should be used as a clue.

Mark Hammond
Collaborator

check for toolbar being visible in rev 627c4b4. According to http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#1360 that is the canonical check, so seems reasonable for now.

Mark Hammond mhammond closed this March 14, 2012
Michael Hanson michaelrhanson reopened this March 30, 2012
Michael Hanson
Collaborator

Reopening; I still see sidebar in some advertising popups. The location bar was present but no navigation controls.

Shane Caraveo
Collaborator

Do we have a solid repro for this?

Shane Caraveo mixedpuppy closed this May 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.