Fixes bug 667028 - Added filter by release channels option to search. #319

Merged
merged 1 commit into from Mar 29, 2013

Conversation

Projects
None yet
2 participants
Member

adngdb commented Mar 28, 2013

No description provided.

@peterbe peterbe commented on an outdated diff Mar 29, 2013

crashstats/crashstats/templates/crashstats/query.html
@@ -81,6 +81,11 @@
</p>
<p class="advanced">
+ <label for="reason">Release Channel</label>
@peterbe

peterbe Mar 29, 2013

Contributor

for="release_channels"

Contributor

peterbe commented Mar 29, 2013

r+ with one nit (on the for attribute).

It bothers me that we're not using the form class to render the actual HTML. Do we really want to maintain all this HTML?

Member

adngdb commented Mar 29, 2013

@peterbe The new Search UI is going to remove that big HTML form. Let's not worry about that for the moment.

@adngdb adngdb added a commit that referenced this pull request Mar 29, 2013

@adngdb adngdb Merge pull request #319 from AdrianGaudebert/667028-release-channel-s…
…earch

Fixes bug 667028 - Added filter by release channels option to search.
5242b11

@adngdb adngdb merged commit 5242b11 into mozilla:master Mar 29, 2013

1 check passed

default Jenkins build 'socorro-crashstats-github' #349 has succeeded
Details

adngdb deleted the adngdb:667028-release-channel-search branch Mar 29, 2013

Contributor

peterbe commented Mar 29, 2013

hehe. I thought this was the new search UI. that goes to show how quickly I looked at it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment