This repository has been archived by the owner on Feb 1, 2018. It is now read-only.
Bug891815 crashes per buildid uses current page #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| version=versions) | ||
| for build in builds: | ||
| os_name = build['platform'] | ||
| build_date = datetime.datetime.strptime(str(build['buildid']), |
There was a problem hiding this comment.
What's the point of this?
Can you just do: buildid = str(build['buildid'])[:8] and get the exact same result?
There was a problem hiding this comment.
I considered that, but if the buildid was somehow mangled or not what we expected it'd be wrong and there'd be no indication of that. Throwing an exception isn't exactly friendly though - I think maybe catching exceptions and falling back to showing the full untruncated build ID would be best. Do you think this is worth it?
|
r+ with nits with disclaimer of lack-of-understanding-the-full-context-and-problem. |
rhelmer
added a commit
that referenced
this pull request
Jul 16, 2013
…es-current-page Bug891815 crashes per buildid uses current page
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.