Skip to content
This repository has been archived by the owner on Jan 31, 2019. It is now read-only.

[bug 1173085] deal with ebs mount edge case #170

Merged
merged 1 commit into from Jun 11, 2015

Conversation

phrawzty
Copy link
Contributor

Since cloud-init is a bit of an unknown for us right now, I reasoned that Puppet presented the most rapid path to dealing with the EBS mount edge case.

I've tested this and, from a system perspective, it appears to work as expected. 馃榿 In terms of actual deployment there are some configuration (Consul) elements that will need to be adjusted. Let's open a dialogue on the best way to roll this out.

r? @rhelmer @jdotpz

key = "Environment"
value = "${var.environment}"
propagate_at_launch = true
key = "Environment"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonus: I fixed some whitespace issues. 馃槒


# There is an edge-case interaction between cloud-init and *some* instance
# types that causes EBS volumes to be pre-mounted.
# https://bugzilla.mozilla.org/show_bug.cgi?id=1173085
exec {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple and decidedly inelegant solution: if the mount is there, unmount it. We can get away with this because we're using a strict role separation model; however, if we ever intend to combine roles, this may be problematic down the line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean by combine roles, like apply multiple roles to the same node?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean if we combine two roles that both expect exclusive use of /dev/xvdb. Unlikely, but wanted to point it out anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good point - yes I would definitely like to handle ephemeral storage in a more general way. I think this is fine for the moment since it's only really critical for processor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ES data nodes also mount this device, fwiw...

@rhelmer
Copy link
Contributor

rhelmer commented Jun 11, 2015

r+, in terms of rollout it's totally fine to just let this go out and configure processor after the fact - incoming jobs will simply be queued up. This is preventing new processor instances from coming up cleanly anyway.

rhelmer added a commit that referenced this pull request Jun 11, 2015
[bug 1173085] deal with ebs mount edge case
@rhelmer rhelmer merged commit 526cec6 into mozilla:master Jun 11, 2015
@phrawzty phrawzty deleted the bug1173085__mount_madness branch June 11, 2015 17:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants