fixes Bug 854456 - Processor2012 C skiplist regex ini configman converter change #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you file a bug for this if there isn't one, and amend the commit message with the bug? |
|
thanks! r+ |
lonnen
added a commit
that referenced
this pull request
Mar 27, 2013
fixes Bug 854456 - Processor2012 C skiplist regex ini configman converter change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The skip list values in ini files are difficult to work with because they're just strings that have been escaped several times over. To simplify them, I've recast them as a python expressions to be evaluated at configuration load time in the same manner that the skip list option "signature_sentinels". This will make them easier to edit and maintain in the ini files.