Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug933963 split up signature summary #1646

Merged
merged 3 commits into from Nov 5, 2013
Merged

Bug933963 split up signature summary #1646

merged 3 commits into from Nov 5, 2013

Conversation

selenamarie
Copy link
Contributor

Splits up the gigantic update_signature_summary() empire into:

update_signature_summary_architecture
update_signature_summary_device
update_signature_summary_flash_version
update_signature_summary_installations
update_signature_summary_os
update_signature_summary_process_type
update_signature_summary_products
update_signature_summary_uptime

I also introduced backfill_named_table(tablename, date) function! This primarily affects DBAs or people who are running backfill manually to fix old data.

Crontabber doesn't use backfill_* functions, so this shouldn't affect production activity. The idea is to eliminate the need for specific backfill_foo functions in the future. I need to audit all existing functions before I can fully deprecate old backfill functions. I have audited all the signature_summary functions affected by this patch and they can all be safely used with backfill_named_table().

* TODO: update all backfill to use new backfill template and update API
* Updated backfill_matviews() to use new signature_summary functions

Backfilling matviews
@brandonsavage
Copy link
Contributor

I tested this for a while and it seems to work, but we need to extensively test it on stage. r+

selenamarie added a commit that referenced this pull request Nov 5, 2013
…e-summary

Bug933963 split up signature summary
@selenamarie selenamarie merged commit 0b2a681 into mozilla-services:master Nov 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants