Bug933963 split up signature summary #1646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits up the gigantic update_signature_summary() empire into:
I also introduced
backfill_named_table(tablename, date)
function! This primarily affects DBAs or people who are running backfill manually to fix old data.Crontabber doesn't use backfill_* functions, so this shouldn't affect production activity. The idea is to eliminate the need for specific
backfill_foo
functions in the future. I need to audit all existing functions before I can fully deprecate old backfill functions. I have audited all the signature_summary functions affected by this patch and they can all be safely used withbackfill_named_table()
.