bug 977917 - totalNumberOfCrashes returned by tcbs is wrong #1922

Merged
merged 1 commit into from Mar 3, 2014

3 participants

@rhelmer
Mozilla member

No description provided.

@rhelmer
Mozilla member

r? @AdrianGaudebert - I don't see a cleaner way to do it with this old code :( Maybe you do!

@adngdb
Mozilla member

@rhelmer Could you please add a test that verifies that number is correct now? Otherwise this looks good to me, I don't think we want to change this service too much unless we decide to rewrite it entirely.

@adngdb
Mozilla member

r+!

@peterbe

Doesn't that need to be added to the API_WHITELIST too?

@rhelmer
Mozilla member

@peterbe it's confusing, we end up removing that extra field since we only want the total in the output once. We can do better here, but not without replacing the query and overhauling this code - that is worth doing, but in the meantime I want to return the correct result :)

@rhelmer rhelmer merged commit aeeda8a into mozilla:master Mar 3, 2014

1 check was pending

Details default Jenkins build 'socorro-github' #2912 is running
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment