Fix collector ini to listen on external interfaces #2140

Merged
merged 2 commits into from Jul 15, 2014

4 participants

@luser
Mozilla member

I stumbled over this while getting my Vagrant VM up and running. If you use collector.ini-dist the collector only listens on localhost and you can't submit to it from outside the VM.

@rhelmer
Mozilla member

Mentioned in IRC - test is failing due to this silly grep: https://github.com/mozilla/socorro/blob/master/scripts/rabbitmq-integration-test.sh#L181

@twobraids - do you think we should make this the default inside collector_app.py itself, so we don't regress this when the configs are periodically regenerated? I think this is the right thing to do - middleware we want on a private interface by default but having collector listen to all makes sense to me.

@rhelmer
Mozilla member

@luser @twobraids actually this seems like less of a big deal now that we promote uwsgi for development - still would be nice to make it consistent

@twobraids
Mozilla member

I have no qualms about changing the default.

why does this PR fail jenkins?

@rhelmer
Mozilla member
@rhelmer
Mozilla member

@luser would you mind fixing the line referred to in #2140 (comment) ? Then we can moige it

@luser
Mozilla member

That changeset is from @lonnen, should fix the issue.

@rhelmer
Mozilla member

@rhelmer rhelmer merged commit 9a486db into mozilla:master Jul 15, 2014

1 check passed

Details default Jenkins build 'socorro-github' #3661 has succeeded
@luser luser deleted the luser:collector-config branch Jul 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment