Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

bug 773835 - cronjob changes for mobeta #773

Merged
merged 1 commit into from over 1 year ago

3 participants

Robert Helmer Josh Berkus Chris Lonnen
Robert Helmer
Collaborator

No description provided.

Josh Berkus
Collaborator

update_tcbs_build is missing.

Were the hourly jobs reset in a separate patch already?

Robert Helmer
Collaborator

@jberkus thanks, fixed. The hourly jobs look ok (they are separate scripts and we can't do explicit dependencies in the old system)

Chris Lonnen
Owner

r+, but should this be targeted at the mobeta branch instead?

Robert Helmer
Collaborator

@lonnen since mobeta is going to merged soon in PR 777 I think we could just wait on that.

Robert Helmer rhelmer merged commit 72c8725 into from August 15, 2012
Robert Helmer rhelmer closed this August 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Aug 02, 2012
Robert Helmer bug 773835 - cronjob changes for mobeta 9a5f4d7
This page is out of date. Refresh to see the latest.
14  socorro/cron/dailyMatviews.py
@@ -21,14 +21,20 @@ def update(config, targetDate):
21 21
       ('update_product_versions', [], []),
22 22
       ('update_signatures', [targetDate], []),
23 23
       ('update_os_versions', [targetDate], []),
24  
-      ('update_tcbs', [targetDate],
25  
-       ['update_product_versions', 'update_signatures', 'update_os_versions']),
  24
+      ('update_tcbs', [targetDate], []),
26 25
       ('update_adu', [targetDate], []),
27  
-      ('update_daily_crashes', [targetDate],
28  
-       ['update_product_versions' 'update_signatures']),
29 26
       ('update_hang_report', [targetDate], []),
30 27
       ('update_rank_compare', [targetDate], []),
31 28
       ('update_nightly_builds', [targetDate], []),
  29
+      ('update_build_adu', [targetDate], []),
  30
+      ('update_crashes_by_user', [targetDate], ['update_adu']),
  31
+      ('update_crashes_by_user_build', [targetDate], []),
  32
+      ('update_correlations', [targetDate], []),
  33
+      ('update_home_page_graph', [targetDate], ['update_adu']),
  34
+      ('update_home_page_graph_build', [targetDate], ['update_build_adu']),
  35
+      ('update_tcbs_build', [targetDate], []),
  36
+      ('update_explosiveness', [targetDate],
  37
+       ['update_tcbs', 'update_build_adu']),
32 38
     )
33 39
 
34 40
     failed = set()
20  socorro/unittest/cron/testDailyMatviews.py
@@ -76,11 +76,15 @@ def test_failing__update_product_versions(self):
76 76
         with patch('socorro.cron.dailyMatviews.logger') as mock_logger:
77 77
             dailyMatviews.update(self.config, 'some date')
78 78
             self.assertEqual(cursor.called, ['update_product_versions',
79  
-              'update_signatures', 'update_os_versions', 'update_adu',
80  
-              'update_daily_crashes', 'update_hang_report',
81  
-              'update_rank_compare', 'update_nightly_builds'])
82  
-            self.assertEqual(mock_logger.info.call_count, 8)
83  
-            self.assertEqual(mock_logger.warn.call_count, 2)
  79
+              'update_signatures', 'update_os_versions', 'update_tcbs',
  80
+              'update_adu', 'update_hang_report',
  81
+              'update_rank_compare', 'update_nightly_builds',
  82
+              'update_build_adu', 'update_crashes_by_user',
  83
+              'update_crashes_by_user_build', 'update_correlations',
  84
+              'update_home_page_graph', 'update_home_page_graph_build',
  85
+              'update_tcbs_build', 'update_explosiveness'])
  86
+            self.assertEqual(mock_logger.info.call_count, 16)
  87
+            self.assertEqual(mock_logger.warn.call_count, 1)
84 88
             self.assertEqual(mock_logger.error.call_count, 0)
85 89
 
86 90
     def test_all_works(self):
@@ -88,7 +92,7 @@ def test_all_works(self):
88 92
         dailyMatviews.psycopg2 = mock_psycopg2(cursor)
89 93
         with patch('socorro.cron.dailyMatviews.logger') as mock_logger:
90 94
             dailyMatviews.update(self.config, 'some date')
91  
-            self.assertEqual(mock_logger.info.call_count, 9)
  95
+            self.assertEqual(mock_logger.info.call_count, 16)
92 96
             self.assertEqual(mock_logger.warn.call_count, 0)
93 97
             self.assertEqual(mock_logger.error.call_count, 0)
94 98
 
@@ -99,6 +103,6 @@ def test_mock_internal_error(self):
99 103
         dailyMatviews.psycopg2 = mock_psycopg2(cursor)
100 104
         with patch('socorro.cron.dailyMatviews.logger') as mock_logger:
101 105
             dailyMatviews.update(self.config, 'some date')
102  
-            self.assertEqual(mock_logger.info.call_count, 8)
103  
-            self.assertEqual(mock_logger.warn.call_count, 1)
  106
+            self.assertEqual(mock_logger.info.call_count, 16)
  107
+            self.assertEqual(mock_logger.warn.call_count, 0)
104 108
             self.assertEqual(mock_logger.error.call_count, 1)
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.