Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

bug 773835 - cronjob changes for mobeta #773

Merged
merged 1 commit into from

3 participants

@rhelmer
Owner

No description provided.

@jberkus
Collaborator

update_tcbs_build is missing.

Were the hourly jobs reset in a separate patch already?

@rhelmer
Owner

@jberkus thanks, fixed. The hourly jobs look ok (they are separate scripts and we can't do explicit dependencies in the old system)

@lonnen
Owner

r+, but should this be targeted at the mobeta branch instead?

@rhelmer
Owner

@lonnen since mobeta is going to merged soon in PR 777 I think we could just wait on that.

@rhelmer rhelmer merged commit 72c8725 into mozilla:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 3, 2012
  1. @rhelmer
This page is out of date. Refresh to see the latest.
View
14 socorro/cron/dailyMatviews.py
@@ -21,14 +21,20 @@ def update(config, targetDate):
('update_product_versions', [], []),
('update_signatures', [targetDate], []),
('update_os_versions', [targetDate], []),
- ('update_tcbs', [targetDate],
- ['update_product_versions', 'update_signatures', 'update_os_versions']),
+ ('update_tcbs', [targetDate], []),
('update_adu', [targetDate], []),
- ('update_daily_crashes', [targetDate],
- ['update_product_versions' 'update_signatures']),
('update_hang_report', [targetDate], []),
('update_rank_compare', [targetDate], []),
('update_nightly_builds', [targetDate], []),
+ ('update_build_adu', [targetDate], []),
+ ('update_crashes_by_user', [targetDate], ['update_adu']),
+ ('update_crashes_by_user_build', [targetDate], []),
+ ('update_correlations', [targetDate], []),
+ ('update_home_page_graph', [targetDate], ['update_adu']),
+ ('update_home_page_graph_build', [targetDate], ['update_build_adu']),
+ ('update_tcbs_build', [targetDate], []),
+ ('update_explosiveness', [targetDate],
+ ['update_tcbs', 'update_build_adu']),
)
failed = set()
View
20 socorro/unittest/cron/testDailyMatviews.py
@@ -76,11 +76,15 @@ def test_failing__update_product_versions(self):
with patch('socorro.cron.dailyMatviews.logger') as mock_logger:
dailyMatviews.update(self.config, 'some date')
self.assertEqual(cursor.called, ['update_product_versions',
- 'update_signatures', 'update_os_versions', 'update_adu',
- 'update_daily_crashes', 'update_hang_report',
- 'update_rank_compare', 'update_nightly_builds'])
- self.assertEqual(mock_logger.info.call_count, 8)
- self.assertEqual(mock_logger.warn.call_count, 2)
+ 'update_signatures', 'update_os_versions', 'update_tcbs',
+ 'update_adu', 'update_hang_report',
+ 'update_rank_compare', 'update_nightly_builds',
+ 'update_build_adu', 'update_crashes_by_user',
+ 'update_crashes_by_user_build', 'update_correlations',
+ 'update_home_page_graph', 'update_home_page_graph_build',
+ 'update_tcbs_build', 'update_explosiveness'])
+ self.assertEqual(mock_logger.info.call_count, 16)
+ self.assertEqual(mock_logger.warn.call_count, 1)
self.assertEqual(mock_logger.error.call_count, 0)
def test_all_works(self):
@@ -88,7 +92,7 @@ def test_all_works(self):
dailyMatviews.psycopg2 = mock_psycopg2(cursor)
with patch('socorro.cron.dailyMatviews.logger') as mock_logger:
dailyMatviews.update(self.config, 'some date')
- self.assertEqual(mock_logger.info.call_count, 9)
+ self.assertEqual(mock_logger.info.call_count, 16)
self.assertEqual(mock_logger.warn.call_count, 0)
self.assertEqual(mock_logger.error.call_count, 0)
@@ -99,6 +103,6 @@ def test_mock_internal_error(self):
dailyMatviews.psycopg2 = mock_psycopg2(cursor)
with patch('socorro.cron.dailyMatviews.logger') as mock_logger:
dailyMatviews.update(self.config, 'some date')
- self.assertEqual(mock_logger.info.call_count, 8)
- self.assertEqual(mock_logger.warn.call_count, 1)
+ self.assertEqual(mock_logger.info.call_count, 16)
+ self.assertEqual(mock_logger.warn.call_count, 0)
self.assertEqual(mock_logger.error.call_count, 1)
Something went wrong with that request. Please try again.