1.0 #30
Merged
1.0 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvehent
force-pushed
the
1.0
branch
4 times, most recently
from
6e3dac4
to
d918d53
Compare
|
lgtm if the new flags have been tried and appear to work. |
|
I should probably add some functional tests for that. |
|
I added a functional test for |
This patch changes the behavior of `-r` to make it behave like the encrypt, decrypt or editing mode: it is now a full roundtrip over an existing encrypted file that decrypts, creates a new data key, encrypts and encrypts the data key with all master keys. This new mode makes it a lot easier to rotate data keys without having to edit files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a number of fixes documented in corresponding issues. All changes are backward compatible, and should be easy to review one by one.
@relud : May I please have a review ?