Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More jit profiling #188

Merged
merged 8 commits into from Jul 1, 2015

Conversation

Projects
None yet
2 participants
@fitzgen
Copy link
Member

fitzgen commented Jun 26, 2015

r? @ejpbruel

A couple code clean ups and also some more big perf gains parsing source maps.

Notable gains are

  • Helping TI out with a constructor for mappings
  • Not eagerly inflating source names, which lets us compare source indices rather than strings when comparing mappings.

fitzgen added some commits Jun 24, 2015

Hoist segment length checks into the segment cache so that we only ch…
…eck length when parsing a segment the first time
Do not eagerly inflate names/sources when parsing source maps.
If we do not inflate the names/sources, then we can compare their indices when
sorting mappings rather than doing string comparisons. This is a huge boost to
performance of parsing source maps, as strcmp was taking about 35% of time.
@ejpbruel

This comment has been minimized.

Copy link

ejpbruel commented on lib/source-map/source-map-consumer.js in b764103 Jul 1, 2015

These are the kind of micro-optimizations I like :-)

@ejpbruel

This comment has been minimized.

Copy link

ejpbruel commented on lib/source-map/util.js in 93f411c Jul 1, 2015

Oh this is a really clever idea. Well done!

@ejpbruel

This comment has been minimized.

Copy link
Contributor

ejpbruel commented Jul 1, 2015

This patch looks good to me. Good catch Nick!

fitzgen added a commit that referenced this pull request Jul 1, 2015

@fitzgen fitzgen merged commit 6d8cb58 into mozilla:master Jul 1, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.