Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More jit profiling #188

Merged
merged 8 commits into from Jul 1, 2015
Merged

More jit profiling #188

merged 8 commits into from Jul 1, 2015

Conversation

@fitzgen
Copy link
Contributor

@fitzgen fitzgen commented Jun 26, 2015

r? @ejpbruel

A couple code clean ups and also some more big perf gains parsing source maps.

Notable gains are

  • Helping TI out with a constructor for mappings
  • Not eagerly inflating source names, which lets us compare source indices rather than strings when comparing mappings.
fitzgen added 8 commits Jun 26, 2015
…eck length when parsing a segment the first time
If we do not inflate the names/sources, then we can compare their indices when
sorting mappings rather than doing string comparisons. This is a huge boost to
performance of parsing source maps, as strcmp was taking about 35% of time.
@ejpbruel
Copy link
Contributor

@ejpbruel ejpbruel commented Jul 1, 2015

This patch looks good to me. Good catch Nick!

fitzgen added a commit that referenced this issue Jul 1, 2015
@fitzgen fitzgen merged commit 6d8cb58 into mozilla:master Jul 1, 2015
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants