Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update source-map TypeScript typings to 0.7.0 #321
First off: Congrats on the excellent 0.7.0 release! I look forward to measuring the performance impact on my memory leak debugger, BLeak.
The TypeScript typings contained within this repository are incorrect for the current version posted to NPM, which has breaking changes from 0.5.0. As a result, TypeScript code is unable to properly interoperate with the latest version of the library.
I have updated the typings to make the SourceMapConsumer constructors return a Promise and to add typings for the new
I have also added a
If you accept and merge this pull request, please publish a new version of source-map to NPM with these changes so TypeScript code can interoperate with 0.7.0! Otherwise, TypeScript code will continue to use the invalid typings file published with the NPM module.
Is it actually an advantage that the typings are included in the source-map package now? Unless you add some tests that the typings are correct (we have an example in Angular if you want) - then it's just an unmaintained extra file, and we would be better off having
There are some advantages if they're included in the package. The user of the library doesn't need to separately a) check if