Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nested consumer usage #330

Merged
merged 3 commits into from Apr 23, 2018

Conversation

@ds300
Copy link
Contributor

commented Apr 21, 2018

Hi! 馃憢

I was excited to test out the latest source-map for react-native-typescript-transformer and ran into an issue with the way the wasm consumer bindings are written. They assume that the callback passed to, e.g. eachMapping will not make use of another consumer. This resulted in an error which I created a regression test for in this PR, along with a fix.

Cheers!

@ds300

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2018

Looks like this fixes #319 too

Copy link
Member

left a comment

Thanks @ds300 !

@fitzgen fitzgen merged commit 8214089 into mozilla:master Apr 23, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fitzgen fitzgen referenced this pull request Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.