Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Index maps support #69

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants

tivac commented Jul 6, 2013

WARNING: TOTALLY INCOMPLETE SO FAR!

This will hopefully fix #16, some day. Issuing PR to get conversation started & make sure I'm not going totally off the rails.

Started building out Simple & Index SourceMapConsumers that inherit from a base SourceMapConsumer that defines shared behavior. Not much progress yet althrough I do have a SimpleSourceMapConsumer passing the basic "this thing can be instantiated test".

tivac added some commits Jul 6, 2013

Start of basic index source map support
- Three main consumer objects now, SourceMapConsumer,
SimpleSourceMapConsumer, and IndexSourceMapConsumer.
- SourceMapConsumer & SimpleSourceMapConsumer are basically identical,
feeling like they should be merged & the canonical SourceMapConsumer
should stay the same.
- Started adding section support to basic SourceMapConsumer
- Wrote async fetching util function & started tests for it but then
commented them out
- Abstracted out safe JSON parsing fn into a util for better sharing
Start pulling pieces out of SourceMapConsumer
- Basically anything not shared goes into either Index/SimpleSMC
- SSMC passing basic instantiation test, basically nothing else.
Tweaked tests to use new object structure.
This will need to be reverted once I have new SourceMapConsumer properly
returning an instance of SimpleSourceMapConsumer or
IndexSourceMapConsumer. Not there yet though.
Re-enabled SimpleSourceMapConsumer tests
Removing errant ISMC test stub.
Member

fitzgen commented Jul 6, 2013

Haven't had time to dig in yet, but I have a quick note: in the tests, you shouldn't need to change the import to SimpleSourceMapConsumer. One of the big discussion points was that existing code using SourceMapConsumer should continue to Just Work, right? ;)

tivac commented Jul 6, 2013

Haven't had time to dig in yet, but I have a quick note: in the tests, you shouldn't need to change the import to SimpleSourceMapConsumer. One of the big discussion points was that existing code using SourceMapConsumer should continue to Just Work, right? ;)

Just a temp thing while I move pieces around a bit & figure out how to hang it all together. Wanted to be sure I hadn't broken everything ever with my renaming. It'll go back to the way it was before I declare this "done" 🐼

@fitzgen fitzgen closed this Sep 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment