Skip to content

Loading…

allow 'names' to be undefined, default to an empty array #85

Merged
merged 1 commit into from

2 participants

@harthur

SASS currently generates source maps without a 'names' property.

@fitzgen
Mozilla member

LGTM, but could you add a comment explaining why we deviate from the spec?

@harthur

This comment adequate?

@fitzgen fitzgen merged commit e4e5bcf into mozilla:master

1 check passed

Details default The Travis CI build passed
@fitzgen
Mozilla member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/source-map/source-map-consumer.js
View
2 lib/source-map/source-map-consumer.js
@@ -52,7 +52,7 @@ define(function (require, exports, module) {
var version = util.getArg(sourceMap, 'version');
var sources = util.getArg(sourceMap, 'sources');
- var names = util.getArg(sourceMap, 'names');
+ var names = util.getArg(sourceMap, 'names', []); // Sass 3.3 leaves out 'names'
var sourceRoot = util.getArg(sourceMap, 'sourceRoot', null);
var sourcesContent = util.getArg(sourceMap, 'sourcesContent', null);
var mappings = util.getArg(sourceMap, 'mappings');
Something went wrong with that request. Please try again.