New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we are implementing CSS Grid 2 #114

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@tantek
Copy link
Member

tantek commented Nov 30, 2018

No description provided.

@dbaron

This comment has been minimized.

Copy link
Member

dbaron commented Nov 30, 2018

While I agree with this, I think it would be good to open an issue in this repository to document the rationale for this position, and link to that issue from the change (mozPositionIssue and maybe also mozPositionDetail).

@dbaron
Copy link
Member

dbaron left a comment

see comment in issue

tantek added some commits Dec 20, 2018

-ws
@tantek

This comment has been minimized.

Copy link
Member

tantek commented Dec 20, 2018

Issue filed: #125 and
updated pull request with mozPositionIssue and mozPositionDetail as requested.

(Originally published at: http://tantek.com/2018/353/t1/)

@dbaron

This comment has been minimized.

Copy link
Member

dbaron commented Dec 20, 2018

The grid part mostly looks good now -- although maybe it's worth working in something about "without removal of semantically important markup" or something like that into it.

However, your attempt to rebase against the intermediate changes didn't go so well, in that git still thinks you haven't rebased even though you have, so it's showing a very large and conflicting diff.

tantek added a commit to tantek/standards-positions-1 that referenced this pull request Dec 20, 2018

semantic elements, try 2 to workaround git
Nested elements and thus subgrid are important for maintaining semantic markup, and this is commit try 2 because git (or maybe GitHub) is too dumb to handle a simple text block diff and instead claims "This branch has conflicts that must be resolved" mozilla#114

dbaron added a commit that referenced this pull request Dec 20, 2018

we are implementing CSS Grid 2 (#114, #126)
Nested elements and thus subgrid are important for maintaining semantic markup.

Fixes #125.
@dbaron

This comment has been minimized.

Copy link
Member

dbaron commented Dec 20, 2018

Moved to #126, although force-pushing to the existing PR would have worked. (The issue was mainly one with git, not with GitHub.)

@dbaron dbaron closed this Dec 20, 2018

@martinthomson

This comment has been minimized.

Copy link
Member

martinthomson commented Dec 20, 2018

Should we sort positions so that we don't get conflicts as a result of always adding to the end?

@mnot

This comment has been minimized.

Copy link
Collaborator

mnot commented Dec 20, 2018

See entry_unique().

dbaron added a commit to dbaron/standards-positions that referenced this pull request Dec 20, 2018

dbaron added a commit that referenced this pull request Dec 20, 2018

dbaron added a commit to dbaron/standards-positions that referenced this pull request Dec 20, 2018

dbaron added a commit that referenced this pull request Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment