Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

[redesign] Refactor check_article_topic and check_article_product #114

Closed
zacc opened this Issue · 6 comments

5 participants

@zacc

We should refactor the check_article_topic and check_article_product methods in knowledge_base_new_article.py to accept the exact string (ie Firefox or Firefox for mobile) of the item they are checking rather than the index.

This will be more in-line with how a user selects options and also how we have written other tests.

@AlinT AlinT was assigned
@AlinT

I'll take this one.

@AndreiH
Collaborator

Is this good to be closed @AlinT ?

@AlinT

No, those methods still need to be refactored. I'll attend to this when I have some spare time since it's not a priority.

@sashakruglov
Collaborator

I can take that one if @AlinT is not working on it

@stephendonner

@sashakruglov go right ahead!

@AlinT

Closing this since it has been done in pull #195

@AlinT AlinT closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.