Skip to content
This repository has been archived by the owner on Mar 5, 2020. It is now read-only.

Use react-router to manage modals #686

Closed
toolness opened this issue Apr 14, 2015 · 1 comment
Closed

Use react-router to manage modals #686

toolness opened this issue Apr 14, 2015 · 1 comment

Comments

@toolness
Copy link
Contributor

As mentioned in #567 and alluded to in #373 (comment), we may want to consider giving modals their own routes, e.g. /mozilla-web-clubs/add for the "add a club" modal. This has a number of benefits:

  • It allows react-router to do much of the work of showing/hiding modals.
  • Links to modals can be shared between users. (For instance, we can share a direct link to the "add a club" modal, rather than sharing a link to the clubs page and telling users to click "add your club").
  • It makes modals easier to develop and debug (devs can just go to the URL of the modal they want to change and reload it).
  • Giving each modal its own URL could make it possible for non-JS and "safe mode" browsers to use modals.
@Pomax
Copy link
Contributor

Pomax commented Dec 22, 2015

react-router has changed so much that we'll be looking at how to update the codebase afresh in 2016

@Pomax Pomax closed this as completed Dec 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants