Add scrolling mozilla marquee to hero unit. #405
Conversation
<marquee> | ||
<span style={{color: 'transparent'}}> | ||
MOZILLAAAAAAAAA!! | ||
</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason this <span>
is needed in Firefox for the <img>
below it to show. Regardless, it provides useful semantic content for screen readers and search engines.
R+ ⚓ |
Is there a reason you didn't belt-and-suspenders it with a `<blink>` tag?
|
Ahh my bad @davidascher, I totally should've done that :) |
I feel like it should star wipe out, actually. |
🌟 🌟 🌟 🌟 👀 |
It's really refreshing to be on a team that takes my ideas seriously. Can we please play a Maroon 5 song automatically on page load? |
for you @hannahkane anything. Does "Sugar" work for you? |
@hannahkane, I'm happy to play a song automatically on page load, but I have concerns about Maroon 5 because their music is copyrighted and we might get a DMCA Takedown notice. Do you happen to like anything Creative Commons licensed, like, say, Jonathan Coulton's rendition of Baby Got Back or Code Monkey? |
Auto play video and songs? What's next a big flash video pre-roll? Think On Thu, Mar 26, 2015, 10:14 AM Atul Varma notifications@github.com wrote:
|
I would totally approve of a flash video pre-roll if it weren't proprietary! But video, that's a good idea... We could maybe have the Choose Independent video playing in the hero unit, or the video for one of the Coulton songs... |
Looks good to me. |
Add scrolling mozilla marquee to hero unit.
This is an attempt at implementing @hannahkane's suggestion in #401 (comment).
The logo appears smaller in Firefox, but the effect is similar.
I'm also pleased to see that JSX/React allows the use of the
<marquee>
tag, and browsers still support it, albeit inconsistently.