Skip to content
This repository has been archived by the owner on Mar 5, 2020. It is now read-only.

Add scrolling mozilla marquee to hero unit. #405

Merged
merged 1 commit into from Mar 26, 2015

Conversation

toolness
Copy link
Contributor

This is an attempt at implementing @hannahkane's suggestion in #401 (comment).

mozilla-marquee

The logo appears smaller in Firefox, but the effect is similar.

I'm also pleased to see that JSX/React allows the use of the <marquee> tag, and browsers still support it, albeit inconsistently.

<marquee>
<span style={{color: 'transparent'}}>
MOZILLAAAAAAAAA!!
</span>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this <span> is needed in Firefox for the <img> below it to show. Regardless, it provides useful semantic content for screen readers and search engines.

@iamjessklein
Copy link
Contributor

R+ :shipit:

@davidascher
Copy link

davidascher commented Mar 25, 2015 via email

@toolness
Copy link
Contributor Author

Ahh my bad @davidascher, I totally should've done that :)

@LauraHilliger
Copy link

I feel like it should star wipe out, actually.

@thisandagain
Copy link

🌟 🌟 🌟 🌟 👀

@hannahkane
Copy link

It's really refreshing to be on a team that takes my ideas seriously. Can we please play a Maroon 5 song automatically on page load?

@iamjessklein
Copy link
Contributor

for you @hannahkane anything. Does "Sugar" work for you?

@toolness
Copy link
Contributor Author

@hannahkane, I'm happy to play a song automatically on page load, but I have concerns about Maroon 5 because their music is copyrighted and we might get a DMCA Takedown notice. Do you happen to like anything Creative Commons licensed, like, say, Jonathan Coulton's rendition of Baby Got Back or Code Monkey?

@jgmac1106
Copy link

Auto play video and songs? What's next a big flash video pre-roll? Think
about GLAMs who may visit the site over and over again in very public
places.

On Thu, Mar 26, 2015, 10:14 AM Atul Varma notifications@github.com wrote:

@hannahkane https://github.com/hannahkane, I'm happy to play a song
automatically on page load, but I have concerns about Maroon 5 because
their music is copyrighted and we might get a DMCA Takedown
http://www.dmca.com/FAQ/What-is-a-DMCA-Takedown notice. Do you happen
to like anything Creative Commons licensed, like, say, Jonathan Coulton's
rendition of Baby Got Back https://www.youtube.com/watch?v=MCWaN_Tc5wo
or Code Monkey https://www.youtube.com/watch?v=qYodWEKCuGg?


Reply to this email directly or view it on GitHub
#405 (comment)
.

@toolness
Copy link
Contributor Author

I would totally approve of a flash video pre-roll if it weren't proprietary! But video, that's a good idea... We could maybe have the Choose Independent video playing in the hero unit, or the video for one of the Coulton songs...

@ScottDowne
Copy link
Contributor

Looks good to me.

ScottDowne added a commit that referenced this pull request Mar 26, 2015
Add scrolling mozilla marquee to hero unit.
@ScottDowne ScottDowne merged commit 7297d81 into mozilla:develop Mar 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants