This repository has been archived by the owner on Mar 5, 2020. It is now read-only.
Move analytics to a module #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,7 +51,8 @@ exports.generateStatic = function(url, cb) { | |||
| }; | |||
|
|
|||
| exports.run = function(location, el) { | |||
| ga.initialize(); | |||
| var options = { debug: false }; | |||
There was a problem hiding this comment.
We can actually set debug to process.env.NODE_ENV != 'production' here, yay!
There was a problem hiding this comment.
Oh wait, that debug thing is quite verbose. Perhaps we should just add a GA_DEBUG env var, and if it is on then we set that flag to true.
|
This looks good to me! You can change the one suggestion I made or just push it, up to you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @toolness - I moved this analytics code out to an npm module https://github.com/adamlofting/react-ga/ so we can use the same logic in other projects.
The module itself could do with test coverage, but I'll follow up with you separately on that task.